Skip to content

Support replaced_by property #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

HebaruSan
Copy link
Member

Motivation

See #904; sometimes after a mod goes out of maintenance, a successor takes its place. It would be helpful if we could give users a cue that this has happened.

Changes

This is #1888 rebased onto current master, plus:

  • Replace checkbox column
  • Replaced by field added to mod info pane
  • Replacements handled in change sets and installer
  • Replaceable filter

For testing, I set up a fake relationship to replace KSP-AVC with ZeroMiniAVC:

image

image

Checking the box updates the change set to remove the replaced mod and install the replacement:

image

Not done:

Fixes #904.
Closes #1888.

Side fixes

  • Reset the Update checkbox when clearing the change set (discovered because we need to do the same with the Replace checkbox)
  • Centralize filter definitions in IsModInFilter rather than implementing them in multiple places
  • Release status in mod info was often wrong because it wasn't updated when null, now it changes to N/A
  • The mod list right click menu now looks better in dark themes

@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI Cmdline Issues affecting the command line Core (ckan.dll) Issues affecting the core part of CKAN Pull request Spec Issues affecting the spec Schema Issues affecting the schema Relationships Issues affecting depends, recommends, etc. ConsoleUI Issues affecting the interactive console UI labels Jan 29, 2019
@HebaruSan HebaruSan added this to the 1.26 milestone Jan 29, 2019
@HebaruSan HebaruSan requested a review from politas January 29, 2019 22:30
@DasSkelett
Copy link
Member

DasSkelett commented Jan 29, 2019

I don't really like having another checkbox column at the beginning, especially one that will be used very rarely.

But I can't think of a better way right now either.

Edit: What about something like this?
Show a warning mark in the Update column and display a message in the mod info panel. Either there we could add a button to mark the mod for replacement (which ticks the update column checkbox) or somewhere else.
ckan-replacedby
(See my amazing photoshop skills...)

@politas
Copy link
Member

politas commented Jan 30, 2019

Yeah, I was trying to work a way of having an image column to indicate either an update or a replacement for the existing checkbox, but kept hitting brick walls.

Copy link
Member

@politas politas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Difficult to really test this out without some actual examples in the metadata, and we can't test that without getting the spec change in place. I think lets merge this and start testing thoroughly. I'll do a pre-release for 1.26 so we can call for thorough testing. Please merge with changelog update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cmdline Issues affecting the command line ConsoleUI Issues affecting the interactive console UI Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI Relationships Issues affecting depends, recommends, etc. Schema Issues affecting the schema Spec Issues affecting the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a replaced_by relationship to allow seamless continuation of deprecated mods
3 participants