-
-
Notifications
You must be signed in to change notification settings - Fork 345
Support replaced_by property #2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yeah, I was trying to work a way of having an image column to indicate either an update or a replacement for the existing checkbox, but kept hitting brick walls. |
a5a2f99
to
192b47b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Difficult to really test this out without some actual examples in the metadata, and we can't test that without getting the spec change in place. I think lets merge this and start testing thoroughly. I'll do a pre-release for 1.26 so we can call for thorough testing. Please merge with changelog update
Motivation
See #904; sometimes after a mod goes out of maintenance, a successor takes its place. It would be helpful if we could give users a cue that this has happened.
Changes
This is #1888 rebased onto current master, plus:
For testing, I set up a fake relationship to replace KSP-AVC with ZeroMiniAVC:
Checking the box updates the change set to remove the replaced mod and install the replacement:
Not done:
any_of
xKAN-meta_testing#45Fixes #904.
Closes #1888.
Side fixes
IsModInFilter
rather than implementing them in multiple places