Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tt-rss: 2018-04-05 -> 2019-01-29 #54896

Merged
merged 1 commit into from Jan 30, 2019
Merged

tt-rss: 2018-04-05 -> 2019-01-29 #54896

merged 1 commit into from Jan 30, 2019

Conversation

Nadrieril
Copy link
Contributor

@Nadrieril Nadrieril commented Jan 29, 2019 •
edited

Motivation for this change

Simple update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

[x] Tested execution of all binary files (usually in ./result/bin/)

This is just a bunch of html and javascript.. Please actually read the checkmarks and test stuff properly.

tt-rss has a NixOS module, you should check to make sure it works with the new version.

@Nadrieril
Copy link
Contributor Author

I assumed the checkmark covered whatever notion of "running it" made sense. I did test the nixos module on my server in production and it works fine.

@infinisil
Copy link
Member

I see, thanks :)

@infinisil infinisil merged commit 7e3647c into NixOS:master Jan 30, 2019
This was referenced Feb 17, 2019
Merged
Merged
FRidh pushed a commit that referenced this pull request Feb 17, 2019
@dasJ @FRidh
tt-rss-theme-feedly: 1.4.0 -> 2.0.0
b1cfee1 
The old version doesn't work anymore since #54896 was merged.
@Nadrieril Nadrieril deleted the update-ttrss branch May 5, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nadrieril @infinisil @GrahamcOfBorg