Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.favicon: init at 0.5.1 #54920

Merged
merged 1 commit into from Jan 30, 2019
Merged

pythonPackages.favicon: init at 0.5.1 #54920

merged 1 commit into from Jan 30, 2019

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

add the favicon package to nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elohmeier elohmeier requested a review from FRidh as a code owner January 30, 2019 08:43
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.favicon python3.pkgs.favicon

dotlambda
dotlambda requested changes Jan 30, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pytest-runner')

pytestrunner needs to be added to buildInputs.

@elohmeier
Copy link
Contributor Author

@dotlambda thanks for your review! I've added the dependency to the buildInputs.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.favicon python3.pkgs.favicon

@dotlambda dotlambda merged commit c995ad0 into NixOS:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elohmeier @dotlambda @GrahamcOfBorg