Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: nixos/httpd: check config syntax validity with httpd -t in preStart #54911

Closed
wants to merge 1 commit into from

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jan 30, 2019

Motivation for this change

Try to keep httpd on par with nginx: #24664

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

@GrahamcOfBorg test proxy

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-january/2002/1

@timokau
Copy link
Member

timokau commented Feb 2, 2019

Good idea! Did you test what it does when the config is invalid? Will it give a useful error message?

@aanderse aanderse changed the title nixos/httpd: check config syntax validity with httpd -t in preStart WIP: nixos/httpd: check config syntax validity with httpd -t in preStart Feb 2, 2019
@aanderse
Copy link
Member Author

This has a slew of problems which I've since discovered... closing for now 😞

@aanderse aanderse closed this Mar 26, 2019
@aanderse aanderse deleted the apache-check-config branch April 6, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants