Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

springLobby: Fix TLS problems on map downloads #54292

Merged
merged 1 commit into from Jan 20, 2019
Merged

springLobby: Fix TLS problems on map downloads #54292

merged 1 commit into from Jan 20, 2019

Conversation

baracoder
Copy link
Contributor

Motivation for this change

Experiencing TLS problems when downloading maps and games through springlobby. Although springlobby downloads a ca-bundle, it will prefer /etc/ssl/certs but expects a set of hashed names inside, which seams not to be the case on my NixOS systems. With this patch, springlobby will use the custom ca-bundle, even if /etc/ssl/certs is present.

cc mainainers @Phreedom @qknight @domenkozar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@domenkozar
Copy link
Member

@GrahamcOfBorg build springlobby

@baracoder baracoder changed the title springlobby: Fix TLS problems on map downloads springLobby: Fix TLS problems on map downloads Jan 19, 2019
@baracoder
Copy link
Contributor Author

The attribute name has a capital L while the package name a lower one

@domenkozar
Copy link
Member

@GrahamcOfBorg build springLobby

@domenkozar domenkozar merged commit cb6281a into NixOS:master Jan 20, 2019
@baracoder baracoder deleted the springlobby-ca-fix branch January 20, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qknight qknight Awaiting requested review from qknight

@Phreedom Phreedom Awaiting requested review from Phreedom

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baracoder @domenkozar @GrahamcOfBorg