Get duration from duration_ms for playing_now listens
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramsingh
force-pushed
the
now-playing-durations
branch
from
8125f7c
to
a2a930d
Compare
paramsingh
changed the title
duration_ms for playing_now listensduration_ms for playing_now listens
mayhem
reviewed
Jan 19, 2019
mayhem
reviewed
Jan 19, 2019
mayhem
approved these changes
Jan 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a Feature Addition
Describe this change in 1-2 sentences: The Spotify API sends us the durations in ms, so if we get a listen with the key
duration_mswe should use it to calculate the expiration time of currently playing tracks.Problem
We were ignoring the
duration_mskey.Solution
Use the
duration_mskey and add tests for expiration.