Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc-arm-embedded: fix MANPATH #54293

Merged
merged 1 commit into from Jan 20, 2019
Merged

gcc-arm-embedded: fix MANPATH #54293

merged 1 commit into from Jan 20, 2019

Conversation

witkamp
Copy link
Contributor

@witkamp witkamp commented Jan 19, 2019

Motivation for this change

Fix isssue #54291

Things done

Add symlink to fix MANPATH

  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • [x ] Fits CONTRIBUTING.md.

rasendubi
rasendubi approved these changes Jan 19, 2019
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superficially looks good.

@rasendubi
Copy link
Member

@GrahamcOfBorg build gcc-arm-embedded gcc-arm-embedded-7 gcc-arm-embedded-6

@rasendubi rasendubi merged commit 5d9024d into NixOS:release-18.09 Jan 20, 2019
@rasendubi
Copy link
Member

@witkamp could you please port the patch to the master branch?

@witkamp
Copy link
Contributor Author

witkamp commented Jan 20, 2019

Ported to master in PR #54386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@witkamp @rasendubi @GrahamcOfBorg