Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udocker: change homepage to documentation on gitbooks.io #54294

Merged
merged 1 commit into from Jan 21, 2019
Merged

udocker: change homepage to documentation on gitbooks.io #54294

merged 1 commit into from Jan 21, 2019

Conversation

das-g
Copy link
Member

@das-g das-g commented Jan 19, 2019

Motivation for this change

That view, other than the currently used gitbook.com one, is available to readers who are not logged into GitBook, too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@das-g
udocker: change homepage to documentation on gitbooks.io
077a5cf 
as that view, other than the gitbook.com one, is available to
readers not logged into GitBook, too.
@das-g
Copy link
Member Author

das-g commented Jan 19, 2019

Alternatively, we could just give the URL to the GitHub repo as the homepage: https://github.com/indigo-dc/udocker

(The README.md there contains a link to the documentation.)

@nlewo
Copy link
Member

nlewo commented Jan 21, 2019

This URL is fine. Thanks.

@nlewo nlewo merged commit 6d4f331 into NixOS:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@das-g @nlewo @GrahamcOfBorg