sbcl: 1.4.7 -> 1.4.9; tested on nixos #42826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build sbcl |
|
Success on x86_64-linux (full log) Attempted: sbcl Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: sbcl Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: sbcl Partial log (click to expand)
|
|
Any ideas what we need to change for aarch64 to work again? Or is there a reason/way to just disable something related to sb-concurrency? |
|
It should work as threads are supported upstream on aarch64-linux and
apart from version bump, there were no changes in nixpkgs connected to
sbcl I think.
Unfortunately I can't see the log at
https://logs.nix.ci/?key=nixos/nixpkgs.42826&attempt_id=3369e726-9c3b-4618-9a3f-2c892eb5de88
as it doesn't work without Javascript.
I also don't have aarch64-linux machine to test this anymore.
It is also possible that sb-concurrency failure is transient. Could it
be tested by grahamc just on aarch64-linux again?
Otherwise one could disable threadSupport on aarch64-linux.
|
|
@GrahamcOfBorg build sbcl |
|
Success on x86_64-darwin (full log) Attempted: sbcl Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: sbcl Partial log (click to expand)
|
|
Weird results in the module test… |
|
Failure on aarch64-linux (full log) Attempted: sbcl Partial log (click to expand)
|
|
Hm, seems to be repeatable. |
|
Michael Raskin <notifications@github.com> writes:
`sb-concurrency` is a contrib module, it should be possible to nuke
just it with less collateral damage than nuking threads completely.
probably sed make-target-contrib.sh and touch
obj/asdf-cache/sb-concurrency/test-passed.test-report at the right place
1 out of 25 total tests failed: SB-CONCURRENCY-TEST::FRLOCK.1.
maybe a timing problem
asking on irc #sbcl could give some ideas, e.g. if that is known issue
sometimes sbcl tests don't work on a platform and need to be marked
accordingly, but i would be surprised if this was the case here
sbcl 1.4.7 worked fine, but unfortunatelly i can't bisect this
|
|
Hm. Looks like an actual consistency problem. Need to look at upstream ML at some point… |
|
1.4.10 seems to lack this problem (and 1.4.11 breaks Maxima…). With 1.4.10 in |
|
Michael Raskin <notifications@github.com> writes:
1.4.10 seems to lack this problem (and 1.4.11 breaks Maxima…). With
1.4.10 in `master` I close this as «unclear whether there is an
upstream problem»
great, thank you
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.