Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 1fb475e7fce5
Choose a base ref
...
head repository: NixOS/nix
compare: 629398d05cc7
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Jun 18, 2018

  1. sync.hh: return cv_status instead of dropping it, in case useful.

    @dtzWill
    dtzWill committed Jun 18, 2018
    Copy the full SHA
    f601bc0 View commit details
    Browse the repository at this point in the history

  2. progress-bar: re-draw last update if nothing new for 1sec. 

    Slightly nicer behavior when updates are somewhat far apart
(during a long linking step, perhaps) ensuring things
don't appear unresponsive.

If we wait the maximum amount for the update,
don't bother waiting another 50ms (for rate-limiting purposes)
and just check if we should quit.

This also ensures we'll notice the request to quit within 1s
if quit is signalled but there is not an udpate.
(I'm not sure if this happens or not)
    @dtzWill
    dtzWill committed Jun 18, 2018
    Copy the full SHA
    44de71a View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2018

  1. Merge pull request #2241 from dtzWill/feature/refresh-progress-bar 

    progress-bar: refresh occasionally even if no updates are received
    @edolstra
    edolstra committed Jun 19, 2018
    Copy the full SHA
    629398d View commit details
    Browse the repository at this point in the history