Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snes9x-gtk: Install normally #42213

Merged
merged 1 commit into from Jun 19, 2018
Merged

snes9x-gtk: Install normally #42213

merged 1 commit into from Jun 19, 2018

Conversation

Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Jun 19, 2018

Motivation for this change

/share was not installed before, thus missing the desktop file.
Added wrapGAppsHook so the executable will know how to handle certain GTK things.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

Thanks!

@Chiiruno Chiiruno deleted the dev/snes9x branch June 19, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants