Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dolphinEmuMaster: 20180609 -> 20180618 #42199

Closed
wants to merge 3 commits into from
Closed

dolphinEmuMaster: 20180609 -> 20180618 #42199

wants to merge 3 commits into from

Conversation

Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Jun 19, 2018 •
edited

Motivation for this change

Version bump, small restructure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

cc @MP2E

@Chiiruno
Copy link
Contributor Author

Chiiruno commented Jun 23, 2018 •
edited

cc @MP2E
Updated to 2018-06-22.

@MP2E
Copy link

MP2E commented Jun 23, 2018 •
edited

Looks great! Thanks for cleaning this derivation up. Pushed as of 794c91b

@MP2E MP2E closed this Jun 23, 2018
@Chiiruno Chiiruno deleted the dev/dolphin-emu branch June 23, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Chiiruno @adisbladis @MP2E @GrahamcOfBorg @Madouura