Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-18.03/pgbackup: Fix bug in postgresql-backup module that causes to fail #42182

Merged
merged 1 commit into from Jun 19, 2018
Merged

nixos-18.03/pgbackup: Fix bug in postgresql-backup module that causes to fail #42182

merged 1 commit into from Jun 19, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

The postgresqlBackup module fails to backup the database.
User root is ignored and pg_dump does not create a backup (at least in newer postgres version?).
See #41388

This is a hotfix for 18.03. See #42133 for a more thorough
refactoring of the postgresqlBackup module.

Things done

Run pg_dump as postgres super user instead of root. Otherwise

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@markuskowa
nixos-18.03/pgbackup: Fix bug in postgresql-backup module that causes
508477f 
pg_dump to fail

Run pg_dump as postgres super user instead of root.
See NixOS#41388
@Mic92 Mic92 merged commit 43d3e53 into NixOS:release-18.03 Jun 19, 2018
@markuskowa markuskowa deleted the pgbackup-18.03 branch June 20, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @Mic92 @GrahamcOfBorg