Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: Abort build on gn warnings. Fixes #42189. #42194

Merged
merged 1 commit into from Jun 19, 2018
Merged

chromium: Abort build on gn warnings. Fixes #42189. #42194

merged 1 commit into from Jun 19, 2018

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jun 19, 2018

Also fix flags that trigger the warning.

Motivation for this change

#42189

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

CC @bendlas

@nh2
chromium: Abort build on gn warnings. Fixes NixOS#42189.
95358db 
Also fix such obsolete flags:

* `use_gconf` was already known to become obsolete with Chromium 65
* `enable_hotwording` has been removed in upstream commit d693f0c7ab
@nh2 nh2 mentioned this pull request Jun 19, 2018
Closed
@Mic92 Mic92 merged commit 9b035d5 into NixOS:master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @Mic92 @GrahamcOfBorg