Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vym: 2.2.4 -> 2.6.11 #42186

Merged
merged 2 commits into from Jun 19, 2018
Merged

vym: 2.2.4 -> 2.6.11 #42186

merged 2 commits into from Jun 19, 2018

Conversation

nek0
Copy link
Contributor

@nek0 nek0 commented Jun 18, 2018

Motivation for this change

The Software available in nixpkgs was outdated, but I rely on it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry. It's my first time making a PR here.

@Mic92 Mic92 changed the title update vym to 2.6.11 vym: 2.2.4 -> 2.6.11 Jun 19, 2018
@Mic92
Copy link
Member

Mic92 commented Jun 19, 2018

@GrahamcOfBorg build vym

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: vym

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vym

Partial log (click to expand)

patching script interpreter paths in /nix/store/hpwc5cnnmd1pk0lyqnb6n9xi6c9qskla-vym-2.6.11
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/hpwc5cnnmd1pk0lyqnb6n9xi6c9qskla-vym-2.6.11/vym/scripts/makedist-vym: interpreter directive changed from "/bin/bash" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash"
/nix/store/hpwc5cnnmd1pk0lyqnb6n9xi6c9qskla-vym-2.6.11/vym/scripts/screencast: interpreter directive changed from "/bin/bash" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash"
/nix/store/hpwc5cnnmd1pk0lyqnb6n9xi6c9qskla-vym-2.6.11/vym/scripts/vivym: interpreter directive changed from "/bin/bash" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash"
/nix/store/hpwc5cnnmd1pk0lyqnb6n9xi6c9qskla-vym-2.6.11/vym/scripts/getbinaries: interpreter directive changed from "/bin/bash" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/hpwc5cnnmd1pk0lyqnb6n9xi6c9qskla-vym-2.6.11...
postPatchMkspecs
postPatchMkspecs
/nix/store/hpwc5cnnmd1pk0lyqnb6n9xi6c9qskla-vym-2.6.11

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vym

Partial log (click to expand)

patching script interpreter paths in /nix/store/pblnz59fslqfnbr9441ca9mx2fdv1dj8-vym-2.6.11
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/pblnz59fslqfnbr9441ca9mx2fdv1dj8-vym-2.6.11/vym/scripts/getbinaries: interpreter directive changed from "/bin/bash" to "/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/bash"
/nix/store/pblnz59fslqfnbr9441ca9mx2fdv1dj8-vym-2.6.11/vym/scripts/makedist-vym: interpreter directive changed from "/bin/bash" to "/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/bash"
/nix/store/pblnz59fslqfnbr9441ca9mx2fdv1dj8-vym-2.6.11/vym/scripts/screencast: interpreter directive changed from "/bin/bash" to "/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/bash"
/nix/store/pblnz59fslqfnbr9441ca9mx2fdv1dj8-vym-2.6.11/vym/scripts/vivym: interpreter directive changed from "/bin/bash" to "/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/pblnz59fslqfnbr9441ca9mx2fdv1dj8-vym-2.6.11...
postPatchMkspecs
postPatchMkspecs
/nix/store/pblnz59fslqfnbr9441ca9mx2fdv1dj8-vym-2.6.11

@Mic92 Mic92 merged commit c89b6f4 into NixOS:master Jun 19, 2018
@Mic92
Copy link
Member

Mic92 commented Jun 19, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nek0 @Mic92 @GrahamcOfBorg @Janik-Haag