progress-bar: refresh occasionally even if no updates are received #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly nicer behavior when updates are somewhat far apart (during a long linking step, perhaps) ensuring things don't appear unresponsive. If we wait the maximum amount for the update, don't bother waiting another 50ms (for rate-limiting purposes) and just check if we should quit. This also ensures we'll notice the request to quit within 1s if quit is signalled but there is not an udpate. (I'm not sure if this happens or not)
|
This is causing issues for me, now the repl resets the line I'm typing on every ~1s, 44de71a specifically. |
|
Yes it probably ly should be reverted for now. Sorry!
I thought I'd submitted a PR doing so,
but don't see it now so perhaps not.
It breaks various other situations slightly as well.
But it was super bad re:repl, haha.
…On Fri, Aug 3, 2018, 4:00 PM Daiderd Jordan ***@***.***> wrote:
This is causing issues for me, now the repl resets the line I'm typing on
every ~1s.
$ nix repl
Welcome to Nix version 2.1pre6338_45bcf541. Type :? for help.
nix-repl>
$ nix repl
Welcome to Nix version 2.1pre6338_45bcf541. Type :? for help.
$ nix repl
Welcome to Nix version 2.1pre6338_45bcf541. Type :? for help.
1+1
$ nix repl
Welcome to Nix version 2.1pre6338_45bcf541. Type :? for help.
$ nix repl
Welcome to Nix version 2.1pre6338_45bcf541. Type :? for help.
1+1
2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2241 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAx4svXBUxpBPNhhGT2p79XVRskM506Uks5uNLoGgaJpZM4UsnEI>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(if updates are far apart don't wait indefinitely to redraw/check for quit)