Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sqlalchemy: 1.2.7 -> 1.2.8 #42180

Closed
wants to merge 1 commit into from
Closed

pythonPackages.sqlalchemy: 1.2.7 -> 1.2.8 #42180

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 18, 2018

http://docs.sqlalchemy.org/en/latest/changelog/changelog_12.html#change-1.2.8

Also fixes test failures w/musl, although I haven't investigated this
further than seeing if they persisted with most recent version O:).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from FRidh as a code owner June 18, 2018 21:19
@dtzWill dtzWill mentioned this pull request Jun 18, 2018
Merged
8 tasks
@dtzWill
Copy link
Member Author

dtzWill commented Jun 18, 2018

Oh I didn't expect so many things to depend on this. Will send to staging instead.

@dtzWill dtzWill changed the base branch from master to staging June 18, 2018 22:56
@dtzWill
Copy link
Member Author

dtzWill commented Jun 18, 2018

(sorry for auto-review-requests issued while rebasing + telling github about it)

@dtzWill
Copy link
Member Author

dtzWill commented Jun 18, 2018

Waiting at least a bit for @FRidh's approval :).

@nh2
Copy link
Contributor

nh2 commented Jun 22, 2018 •
edited

@dtzWill What does the error look like that this fixes? Could you post them?

I found some other python tests in some other builds (dependencies of ghc) failing with musl that are related to TCP buffers (namely pyca/pyopenssl#768), and woud like to know if this is somewhat similar.

@FRidh FRidh self-assigned this Jun 22, 2018
@FRidh
Copy link
Member

FRidh commented Jun 22, 2018

I've just pushed this update to staging.

@FRidh FRidh closed this Jun 22, 2018
@nh2 nh2 mentioned this pull request Sep 11, 2018
Closed
@nh2 nh2 mentioned this pull request Nov 13, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: emacs 6.topic: golang 6.topic: haskell 6.topic: python 6.topic: stdenv Standard environment 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @nh2 @FRidh @GrahamcOfBorg