Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire-desktop: 3.0.2816 -> 3.2.2840 #42943

Merged
merged 1 commit into from Jul 3, 2018
Merged

wire-desktop: 3.0.2816 -> 3.2.2840 #42943

merged 1 commit into from Jul 3, 2018

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Jul 3, 2018 •
edited

Motivation for this change

There's an update.

Here's the release notes
and also a comparison to the prior release.

The issues with strange text artifacts seems to have been corrected also.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    556194384
    405147904
  • Fits CONTRIBUTING.md.

I did not test this on i686-linux

@infinisil
Copy link
Member

@GrahamcOfBorg build wire-desktop

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: wire-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wire-desktop

Partial log (click to expand)

copying path '/nix/store/hags61lgkv6hr7ymmdlrjvb4vwq072mr-xdg-utils-1.1.2' from 'https://cache.nixos.org'...

trying https://wire-app.wire.com/linux/debian/pool/main/wire_3.2.2840_amd64.deb
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 36.9M  100 36.9M    0     0  6844k      0  0:00:05  0:00:05 --:--:-- 7600k
building '/nix/store/vwm8fi15ibqka8bgrpk3543lc1vdzhd8-wire-desktop-3.2.2840.drv'...
unpacking sources
installing
/nix/store/qndgc82hnm05xfin6x1yif4jikq3ga3y-wire-desktop-3.2.2840

@infinisil
Copy link
Member

Ah, aarch64 != i686-linux, I was hoping for @GrahamcOfBorg to build it.

Thanks!

@infinisil infinisil merged commit 3e0db31 into NixOS:master Jul 3, 2018
@worldofpeace worldofpeace deleted the wire-desktop-3.0.2840 branch July 3, 2018 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @infinisil @GrahamcOfBorg