Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.grpcio: use correct license #42944

Merged
merged 1 commit into from Jul 3, 2018
Merged

pythonPackages.grpcio: use correct license #42944

merged 1 commit into from Jul 3, 2018

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Jul 3, 2018

Motivation for this change

While submitting #42939, which started off as copy/paste of grpcio, @dotlambda noticed the license was incorrect. I checked pypi and github and saw that this package was incorrect also.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mmlb mmlb requested a review from FRidh as a code owner July 3, 2018 21:01
@dotlambda dotlambda merged commit 7db99ba into NixOS:master Jul 3, 2018
@dotlambda
Copy link
Member

Thanks!

@mmlb mmlb deleted the fix-python-grpcio-license branch July 3, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants