Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/search.sh: minor fix to unbreak tests after search ux merge #2268

Merged
merged 1 commit into from Jul 4, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 3, 2018

No description provided.

@dtzWill
Copy link
Member Author

dtzWill commented Jul 3, 2018

(as seen on Hydra or anywhere someone tries to build Nix from master since: https://hydra.nixos.org/eval/1466850 )

@Ma27
Copy link
Member

Ma27 commented Jul 3, 2018

ouch, thanks a lot for fixing it! :)

@dtzWill
Copy link
Member Author

dtzWill commented Jul 3, 2018

No worries!

Unrelated but this is the sort of thing it'd be nice to have Travis or hydra-based bots/badges tracking :).

And tests being overly sensitive to output formatting (that's not a fixed format) is unfortunate anyway, so of all the tests to "fail" / need adjusting... this one's just asking t,o be broken by perfectly reasonable changes :).

It's possible I wrote it :P.

@edolstra edolstra merged commit 3defdcc into NixOS:master Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants