Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.keyutils: fix build #42950

Merged
merged 1 commit into from
Jul 4, 2018
Merged

pythonPackages.keyutils: fix build #42950

merged 1 commit into from
Jul 4, 2018
+9 −7

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jul 3, 2018 •
edited
Loading

Motivation for this change

Fixes the Hydra CI build of python{3,2}Packages.keyutils on nixpkgs.
This patch changes the source retrieval to fetchFromGitHub as the PYPI
tarball doesn't come with tests for the check phase.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Ma27 Ma27 requested a review from FRidh as a code owner July 3, 2018 21:49
dotlambda
dotlambda reviewed Jul 4, 2018
View reviewed changes
pkgs/development/python-modules/keyutils/default.nix Outdated
src = fetchPypi {
inherit pname version;
sha256 = "0dskys71vkn59vlsfs1ljli0qnzk7b10iv4pawxawnk2hvyjrf10";
src = fetchFromGitHub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment why GitHub is used.

dotlambda
dotlambda reviewed Jul 4, 2018
View reviewed changes
pkgs/development/tools/database/sqlitebrowser/default.nix Outdated
@@ -1,5 +1,6 @@
{ mkDerivation, lib, fetchFromGitHub, cmake, antlr
, qtbase, qttools, qscintilla, sqlite }:
, qtbase, qttools, qscintilla, sqlite
}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has nothing to do with keyutils.

@Ma27
pythonPackages.keyutils: fix build
7703bd9 
Fixes the Hydra CI build of `python{3,2}Packages.keyutils` on `nixpkgs.`
This patch changes the source retrieval to fetchFromGitHub as the PYPI
tarball doesn't come with tests for the check phase.
@Ma27 Ma27 force-pushed the fix-py-keyutils branch from 87fa481 to 7703bd9 Compare July 4, 2018 11:15
@xeji
Copy link
Contributor

xeji commented Jul 4, 2018

@GrahamcOfBorg build python27Packages.keyutils python36Packages.keyutils

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python27Packages.keyutils, python36Packages.keyutils

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.keyutils, python36Packages.keyutils

Partial log (click to expand)

============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/source, inifile: setup.cfg
collected 9 items

test/keyutils_test.py .........                                          [100%]

=========================== 9 passed in 1.61 seconds ===========================
/nix/store/xd4p82552wwmdliv2qv9a6xfb3a0k1zj-python2.7-keyutils-0.5
/nix/store/lcmrp2hjdjzhy9lg0m57hbv93wj4dsj5-python3.6-keyutils-0.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.keyutils, python36Packages.keyutils

Partial log (click to expand)

============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/source, inifile: setup.cfg
collected 9 items

test/keyutils_test.py .........                                          [100%]

=========================== 9 passed in 1.65 seconds ===========================
/nix/store/5ca5sngrywagwgs5w0i9pfmiq1l0ah8r-python2.7-keyutils-0.5
/nix/store/lwg7hj4i1wl0k1g5a58h68xkmc6wx51j-python3.6-keyutils-0.5

@xeji xeji merged commit c6bea11 into NixOS:master Jul 4, 2018
@Ma27 Ma27 deleted the fix-py-keyutils branch July 4, 2018 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @xeji @GrahamcOfBorg @dotlambda