Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libaom: 0.1.0 -> 1.0.0 #42954

Merged
merged 1 commit into from Jul 7, 2018
Merged

libaom: 0.1.0 -> 1.0.0 #42954

merged 1 commit into from Jul 7, 2018

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Jul 3, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @kiloreux

kiloreux
kiloreux approved these changes Jul 3, 2018
View reviewed changes
Copy link
Member

@kiloreux kiloreux left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I wander why you added python? is it needed now?

@dywedir
Copy link
Member Author

dywedir commented Jul 3, 2018 •
edited

Should i disable the tests? Python is needed for them

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libaom

Partial log (click to expand)

-- Installing: /nix/store/vfgwmkb1dshdd0c0pmy744fbgflbrfwg-libaom-1.0.0/bin/aomenc
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vfgwmkb1dshdd0c0pmy744fbgflbrfwg-libaom-1.0.0
shrinking /nix/store/vfgwmkb1dshdd0c0pmy744fbgflbrfwg-libaom-1.0.0/bin/aomdec
shrinking /nix/store/vfgwmkb1dshdd0c0pmy744fbgflbrfwg-libaom-1.0.0/bin/aomenc
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vfgwmkb1dshdd0c0pmy744fbgflbrfwg-libaom-1.0.0/lib  /nix/store/vfgwmkb1dshdd0c0pmy744fbgflbrfwg-libaom-1.0.0/bin
patching script interpreter paths in /nix/store/vfgwmkb1dshdd0c0pmy744fbgflbrfwg-libaom-1.0.0
checking for references to /build in /nix/store/vfgwmkb1dshdd0c0pmy744fbgflbrfwg-libaom-1.0.0...
/nix/store/vfgwmkb1dshdd0c0pmy744fbgflbrfwg-libaom-1.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libaom

Partial log (click to expand)

-- Installing: /nix/store/5sjxhxd179vax3g5f5r9hvy6am501isd-libaom-1.0.0/bin/aomenc
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5sjxhxd179vax3g5f5r9hvy6am501isd-libaom-1.0.0
shrinking /nix/store/5sjxhxd179vax3g5f5r9hvy6am501isd-libaom-1.0.0/bin/aomenc
shrinking /nix/store/5sjxhxd179vax3g5f5r9hvy6am501isd-libaom-1.0.0/bin/aomdec
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5sjxhxd179vax3g5f5r9hvy6am501isd-libaom-1.0.0/lib  /nix/store/5sjxhxd179vax3g5f5r9hvy6am501isd-libaom-1.0.0/bin
patching script interpreter paths in /nix/store/5sjxhxd179vax3g5f5r9hvy6am501isd-libaom-1.0.0
checking for references to /build in /nix/store/5sjxhxd179vax3g5f5r9hvy6am501isd-libaom-1.0.0...
/nix/store/5sjxhxd179vax3g5f5r9hvy6am501isd-libaom-1.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libaom

Partial log (click to expand)

-- Installing: /nix/store/87vxcx96k6pviil51smm7493lpbvw8gm-libaom-1.0.0/bin/aomenc
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/87vxcx96k6pviil51smm7493lpbvw8gm-libaom-1.0.0
shrinking /nix/store/87vxcx96k6pviil51smm7493lpbvw8gm-libaom-1.0.0/bin/aomdec
shrinking /nix/store/87vxcx96k6pviil51smm7493lpbvw8gm-libaom-1.0.0/bin/aomenc
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/87vxcx96k6pviil51smm7493lpbvw8gm-libaom-1.0.0/lib  /nix/store/87vxcx96k6pviil51smm7493lpbvw8gm-libaom-1.0.0/bin
patching script interpreter paths in /nix/store/87vxcx96k6pviil51smm7493lpbvw8gm-libaom-1.0.0
checking for references to /build in /nix/store/87vxcx96k6pviil51smm7493lpbvw8gm-libaom-1.0.0...
/nix/store/87vxcx96k6pviil51smm7493lpbvw8gm-libaom-1.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libaom

Partial log (click to expand)

-- Installing: /nix/store/zid52b5wgyv06ac7d7zra9b01a01l816-libaom-1.0.0/bin/aomenc
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zid52b5wgyv06ac7d7zra9b01a01l816-libaom-1.0.0
shrinking /nix/store/zid52b5wgyv06ac7d7zra9b01a01l816-libaom-1.0.0/bin/aomenc
shrinking /nix/store/zid52b5wgyv06ac7d7zra9b01a01l816-libaom-1.0.0/bin/aomdec
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zid52b5wgyv06ac7d7zra9b01a01l816-libaom-1.0.0/lib  /nix/store/zid52b5wgyv06ac7d7zra9b01a01l816-libaom-1.0.0/bin
patching script interpreter paths in /nix/store/zid52b5wgyv06ac7d7zra9b01a01l816-libaom-1.0.0
checking for references to /build in /nix/store/zid52b5wgyv06ac7d7zra9b01a01l816-libaom-1.0.0...
/nix/store/zid52b5wgyv06ac7d7zra9b01a01l816-libaom-1.0.0

@kiloreux
Copy link
Member

kiloreux commented Jul 3, 2018

No need to disable tests. Please keep them.

@infinisil infinisil merged commit e72aa92 into NixOS:master Jul 7, 2018
@dywedir dywedir deleted the libaom branch July 8, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiloreux kiloreux kiloreux approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dywedir @GrahamcOfBorg @kiloreux @infinisil