Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 52.8.0 -> 52.9.0 [Critical security fixes] #43012

Merged
merged 2 commits into from Jul 6, 2018
Merged

thunderbird, thunderbird-bin: 52.8.0 -> 52.9.0 [Critical security fixes] #43012

merged 2 commits into from Jul 6, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jul 4, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@coretemp
Copy link
Contributor

coretemp commented Jul 4, 2018

This can be merged as is, but it would be useful if you could introduce a variable with the version, such that size of the diff for the next time this changes is cut in about half.

I.e.

let thunderbird_version = "52.9.0"; in 
<rest of code>

(The version should be specified at most once in the whole file.)

@vcunat
Copy link
Member

vcunat commented Jul 4, 2018

@GrahamcOfBorg build thunderbird

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: thunderbird

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: thunderbird

Partial log (click to expand)

these derivations will be built:
  /nix/store/dhhfvbspprp3hb6qx7c7hmszj388hp1x-thunderbird-52.9.0.drv
waiting for locks or build slots...
/nix/store/wjic1fs8qmww5r9ydgi3qa9mpzzkpkn3-thunderbird-52.9.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: thunderbird

Partial log (click to expand)

                                                    ^
/build/objdir/dist/include/mozilla/mozalloc.h:183:34: note: in expansion of macro 'MOZALLOC_THROW_BAD_ALLOC_IF_HAS_EXCEPTIONS'
 #define MOZALLOC_THROW_BAD_ALLOC MOZALLOC_THROW_BAD_ALLOC_IF_HAS_EXCEPTIONS
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/objdir/dist/include/mozilla/mozalloc.h:204:35: note: in expansion of macro 'MOZALLOC_THROW_BAD_ALLOC'
 void* operator new[](size_t size) MOZALLOC_THROW_BAD_ALLOC
                                   ^~~~~~~~~~~~~~~~~~~~~~~~
make[3]: Entering directory '/build/objdir/image/decoders/icon/gtk'
building of '/nix/store/yns4ra0fyr4wgffy95kpym7017w0zcxd-thunderbird-52.9.0.drv' timed out after 3600 seconds
error: build of '/nix/store/yns4ra0fyr4wgffy95kpym7017w0zcxd-thunderbird-52.9.0.drv' failed

@vcunat vcunat self-assigned this Jul 6, 2018
vcunat
vcunat approved these changes Jul 6, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested thunderbird atop 18.03 for about a day; no regressions.

@vcunat vcunat merged commit 1389274 into NixOS:master Jul 6, 2018
vcunat added a commit that referenced this pull request Jul 6, 2018
@vcunat
Merge #43012: thunderbird*: 52.8.0 -> 52.9.0 (security)
07ac571
vcunat added a commit that referenced this pull request Jul 6, 2018
@vcunat
Merge #43012: thunderbird*: 52.8.0 -> 52.9.0 (security)
477b53d 
(cherry picked from commit 07ac571)
@vcunat vcunat added the 8.has: port to stable A PR already has a backport to the stable release. label Jul 6, 2018
@taku0
Copy link
Contributor Author

taku0 commented Jul 6, 2018

@coretemp sorry for missing your reply. I will fix it at the next update.

@taku0 taku0 mentioned this pull request Jul 12, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @coretemp @vcunat @GrahamcOfBorg