Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackaes.grpcio-tools: init at 1.13.0 #43022

Merged
merged 1 commit into from Jul 5, 2018
Merged

pythonPackaes.grpcio-tools: init at 1.13.0 #43022

merged 1 commit into from Jul 5, 2018

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Jul 4, 2018

Motivation for this change

The seemingly only documented way of generating python grpc code is via the protoc python module, which is contained in this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Reopening of #42939
PTAL @dotlambda

@mmlb mmlb requested a review from FRidh as a code owner July 4, 2018 14:29
pSub
pSub requested changes Jul 4, 2018
View reviewed changes
pkgs/development/python-modules/grpcio-tools/default.nix Outdated

propagatedBuildInputs = [ grpc grpcio ];

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you disable tests? Please provide a comment with the reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mmlb
Copy link
Contributor Author

mmlb commented Jul 4, 2018

@pSub PTAL, also I have no idea why ci failed there any thoughts on it?

@grahamc
Copy link
Member

grahamc commented Jul 4, 2018

@GrahamcOfBorg eval

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.grpcio-tools python3.pkgs.grpcio-tools

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.grpcio-tools, python3.pkgs.grpcio-tools

Partial log (click to expand)

/build/grpcio-tools-1.13.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mzgqaaz6hw0cisyappxjhjl8bj5hw16q-python3.6-grpcio-tools-1.13.0
shrinking /nix/store/mzgqaaz6hw0cisyappxjhjl8bj5hw16q-python3.6-grpcio-tools-1.13.0/lib/python3.6/site-packages/grpc_tools/_protoc_compiler.cpython-36m-x86_64-linux-gnu.so
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mzgqaaz6hw0cisyappxjhjl8bj5hw16q-python3.6-grpcio-tools-1.13.0/lib
patching script interpreter paths in /nix/store/mzgqaaz6hw0cisyappxjhjl8bj5hw16q-python3.6-grpcio-tools-1.13.0
checking for references to /build in /nix/store/mzgqaaz6hw0cisyappxjhjl8bj5hw16q-python3.6-grpcio-tools-1.13.0...
/nix/store/f5nbfl1qc3p15pyccsfnq886zsb8y47b-python2.7-grpcio-tools-1.13.0
/nix/store/mzgqaaz6hw0cisyappxjhjl8bj5hw16q-python3.6-grpcio-tools-1.13.0

@dotlambda dotlambda merged commit 905db9d into NixOS:master Jul 5, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.grpcio-tools, python3.pkgs.grpcio-tools

Partial log (click to expand)

/build/grpcio-tools-1.13.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r3bmpl079k8hqqhkj6sscvdnixq6693l-python2.7-grpcio-tools-1.13.0
shrinking /nix/store/r3bmpl079k8hqqhkj6sscvdnixq6693l-python2.7-grpcio-tools-1.13.0/lib/python2.7/site-packages/grpc_tools/_protoc_compiler.so
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r3bmpl079k8hqqhkj6sscvdnixq6693l-python2.7-grpcio-tools-1.13.0/lib
patching script interpreter paths in /nix/store/r3bmpl079k8hqqhkj6sscvdnixq6693l-python2.7-grpcio-tools-1.13.0
checking for references to /build in /nix/store/r3bmpl079k8hqqhkj6sscvdnixq6693l-python2.7-grpcio-tools-1.13.0...
/nix/store/r3bmpl079k8hqqhkj6sscvdnixq6693l-python2.7-grpcio-tools-1.13.0
/nix/store/53p3pz1sllxwdzld7f9pmap04b9y49n9-python3.6-grpcio-tools-1.13.0

@mmlb mmlb deleted the python-grpcio-tools branch July 5, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmlb @grahamc @dotlambda @GrahamcOfBorg @pSub