Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wcc: init unstable at 2018-04-05 #43014

Merged
merged 1 commit into from Jul 4, 2018
Merged

wcc: init unstable at 2018-04-05 #43014

merged 1 commit into from Jul 4, 2018

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Jul 4, 2018

Motivation for this change

This adds the tools that, among other things, can convert ELF shared objects to ELF static objects, pointed out by @dezgeg at #41935 (comment)

wsh does not seem to be able to find symbols in any library other than libc, but everything else works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: wcc

Partial log (click to expand)

make[2]: Entering directory '/build/source/src/wcc'
gcc -W -Wall -Wno-discarded-qualifiers -Wno-int-conversion -Wno-unused-parameter -Wno-unused-function -Wno-unused-result -fpie -pie -fPIC -g3 -ggdb -I../../include  -I./include/sflib/ -I./include -I../../include/  -Wno-incompatible-pointer-types  -fstack-protector-all -Wl,-z,relro,-z,now -DPACKAGE -DPACKAGE_VERSION -masm=intel -rdynamic -D_FORTIFY_SOURCE=2 -O2 wcc.c -o wcc -lbfd -lelf -lcapstone
gcc: error: unrecognized command line option '-masm=intel'
make[2]: *** [Makefile:29: all] Error 1
make[2]: Leaving directory '/build/source/src/wcc'
make[1]: *** [Makefile:11: all] Error 2
make[1]: Leaving directory '/build/source/src'
make: *** [Makefile:14: all] Error 2
builder for '/nix/store/kqwsihkdmc2j3jshaw2si3myljnhh0na-wcc-unstable-2018-04-05.drv' failed with exit code 2
error: build of '/nix/store/kqwsihkdmc2j3jshaw2si3myljnhh0na-wcc-unstable-2018-04-05.drv' failed

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: wcc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wcc

Partial log (click to expand)

shrinking /nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin/wld
gzipping man pages under /nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin
patching script interpreter paths in /nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05
/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/share/wcc/scripts/md5.wsh: interpreter directive changed from "/home/jonathan/solution-exp/unlinking/awareness/self/wcc/src/wsh/wsh" to "/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin/wsh"
/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/share/wcc/scripts/read.wsh: interpreter directive changed from "/home/jonathan/solution-exp/unlinking/awareness/self/wcc/src/wsh/wsh" to "/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin/wsh"
/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin/wcch: interpreter directive changed from "/usr/bin/wsh" to "/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin/wsh"
/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin/wldd: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05...

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: wcc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wcc

Partial log (click to expand)

shrinking /nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin/wsh
gzipping man pages under /nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin
patching script interpreter paths in /nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05
/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin/wldd: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin/wcch: interpreter directive changed from "/usr/bin/wsh" to "/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin/wsh"
/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/share/wcc/scripts/md5.wsh: interpreter directive changed from "/home/jonathan/solution-exp/unlinking/awareness/self/wcc/src/wsh/wsh" to "/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin/wsh"
/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/share/wcc/scripts/read.wsh: interpreter directive changed from "/home/jonathan/solution-exp/unlinking/awareness/self/wcc/src/wsh/wsh" to "/nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05/bin/wsh"
checking for references to /build in /nix/store/fr0ph1v2xrf6kw8j3x75yp8ifbvgid7a-wcc-unstable-2018-04-05...

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: wcc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@dtzWill
Copy link
Member

dtzWill commented Jul 4, 2018

LGTM! Haven't used it extensively but builds and seems to work on the examples I tried (going through the "Getting Started").

@dtzWill dtzWill merged commit 37914c8 into NixOS:master Jul 4, 2018
@dezgeg dezgeg mentioned this pull request Jul 19, 2018
Open
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @GrahamcOfBorg @dtzWill