Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor codegen_binary_op #6330

Merged
merged 2 commits into from
Jul 4, 2018

Conversation

bcardiff
Copy link
Member

@bcardiff bcardiff commented Jul 4, 2018

This refactor is needed/handy as part of supporting overflowing operators.

bcardiff added 2 commits July 4, 2018 12:10
since it's done in codegen_primitive and others codegen_binary avoids setting it
More linear code for operators
@bew
Copy link
Contributor

bew commented Jul 4, 2018

So is @last set somewhere after? Or is it simply removed?

@bcardiff
Copy link
Member Author

bcardiff commented Jul 4, 2018

@bew @last is used as the last llvm value and is set at codegen_primitive based on the return value of codegen_primitive_* methods. It was probably a left over of past refactors that the @last was mentioned in codegen_primitive_binary.

@bcardiff bcardiff merged commit 7aa7628 into crystal-lang:master Jul 4, 2018
@bcardiff bcardiff added this to the Next milestone Jul 4, 2018
@RX14 RX14 modified the milestones: Next, 0.26.0 Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants