Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libraw: 0.18.12 -> 0.19.0 #42988

Merged
merged 1 commit into from Oct 13, 2018
Merged

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jul 4, 2018

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.

This update was made based on information from https://repology.org/metapackage/libraw/versions.

These checks were done:

  • built on NixOS
  • /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/raw-identify passed the binary check.
  • /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/unprocessed_raw passed the binary check.
  • /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/4channels passed the binary check.
  • /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/simple_dcraw passed the binary check.
  • /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/mem_image passed the binary check.
  • /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/dcraw_half passed the binary check.
  • /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/half_mt passed the binary check.
  • /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/multirender_test passed the binary check.
  • /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/postprocessing_benchmark passed the binary check.
  • /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/dcraw_emu passed the binary check.
  • 10 of 10 passed binary check by having a zero exit code.
  • 0 of 10 passed binary check by having the new version present in output.
  • found 0.19.0 with grep in /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0
  • directory tree listing: https://gist.github.com/d21a46bb80b662baa7febf18eab4e313
  • du listing: https://gist.github.com/02a9d0af77dcf1045b4d3c5f7d17528f

meta.description for libraw is: '"Library for reading RAW files obtained from digital photo cameras (CRW/CR2, NEF, RAF, DNG, and others)"'.

This build is cached with Cachix. To use the cache follow these instructions:

One time setup in nixpkgs Git checkout:

cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:

git fetch r-ryantm && git checkout 92d48c6a21a0fe1c814d611b8a923688404f83f0 && nix-shell --pure -I nixpkgs=. -p libraw

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.

This update was made based on information from https://repology.org/metapackage/libraw/versions.

These checks were done:

- built on NixOS
- /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/raw-identify passed the binary check.
- /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/unprocessed_raw passed the binary check.
- /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/4channels passed the binary check.
- /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/simple_dcraw passed the binary check.
- /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/mem_image passed the binary check.
- /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/dcraw_half passed the binary check.
- /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/half_mt passed the binary check.
- /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/multirender_test passed the binary check.
- /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/postprocessing_benchmark passed the binary check.
- /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0/bin/dcraw_emu passed the binary check.
- 10 of 10 passed binary check by having a zero exit code.
- 0 of 10 passed binary check by having the new version present in output.
- found 0.19.0 with grep in /nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0
- directory tree listing: https://gist.github.com/d21a46bb80b662baa7febf18eab4e313
- du listing: https://gist.github.com/02a9d0af77dcf1045b4d3c5f7d17528f
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libraw

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/aw0yi5m12aymbx97082sq2zq8p1f6c8h-libraw-0.19.0-dev
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/aw0yi5m12aymbx97082sq2zq8p1f6c8h-libraw-0.19.0-dev/lib
patching script interpreter paths in /nix/store/aw0yi5m12aymbx97082sq2zq8p1f6c8h-libraw-0.19.0-dev
checking for references to /build in /nix/store/aw0yi5m12aymbx97082sq2zq8p1f6c8h-libraw-0.19.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/3j7frdy10kf0l46xsgahxq37y4lgc32i-libraw-0.19.0-doc
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3j7frdy10kf0l46xsgahxq37y4lgc32i-libraw-0.19.0-doc
checking for references to /build in /nix/store/3j7frdy10kf0l46xsgahxq37y4lgc32i-libraw-0.19.0-doc...
/nix/store/c152az463594l2si39h4assahzv5wv6r-libraw-0.19.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libraw

Partial log (click to expand)

patching script interpreter paths in /nix/store/fkpa8h5kalch3z38cccd9nr767lzbrl7-libraw-0.19.0
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/k1jvaswdy3kcqrj8pdjbwva15s7ncirg-libraw-0.19.0-lib/lib
patching script interpreter paths in /nix/store/k1jvaswdy3kcqrj8pdjbwva15s7ncirg-libraw-0.19.0-lib
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/fs1y4zbrsl7h0rb1miy1ah93gxa7s0s8-libraw-0.19.0-dev/lib
patching script interpreter paths in /nix/store/fs1y4zbrsl7h0rb1miy1ah93gxa7s0s8-libraw-0.19.0-dev
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/07dh0scsr35fkh6yir9qj44djxsvsfgf-libraw-0.19.0-doc
/nix/store/fkpa8h5kalch3z38cccd9nr767lzbrl7-libraw-0.19.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libraw

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/p1xsirhrfiw8hxlsdzs1cpv14zkyp0lg-libraw-0.19.0-dev
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p1xsirhrfiw8hxlsdzs1cpv14zkyp0lg-libraw-0.19.0-dev/lib
patching script interpreter paths in /nix/store/p1xsirhrfiw8hxlsdzs1cpv14zkyp0lg-libraw-0.19.0-dev
checking for references to /build in /nix/store/p1xsirhrfiw8hxlsdzs1cpv14zkyp0lg-libraw-0.19.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/yd7s55dp6m2xkyqz95xpwlkbziqhka93-libraw-0.19.0-doc
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/yd7s55dp6m2xkyqz95xpwlkbziqhka93-libraw-0.19.0-doc
checking for references to /build in /nix/store/yd7s55dp6m2xkyqz95xpwlkbziqhka93-libraw-0.19.0-doc...
/nix/store/hm11lmikf95b2iddk7pvsq530fzsli61-libraw-0.19.0

@infinisil
Copy link
Member

This makes the krita build fail:

/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp: In member function 'bool KDcrawIface::KDcraw::Private::loadFromLibraw(const QString&, QByteArray&, int&, int&, int&)':
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:381:32: error: 'struct libraw_output_params_t' has no member named 'linenoise'
             raw.imgdata.params.linenoise    = m_parent->m_rawDecodingSettings.NRThreshold * 2.11E-5 + 0.00111111;
                                ^~~~~~~~~
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:382:32: error: 'struct libraw_output_params_t' has no member named 'cfaline'
             raw.imgdata.params.cfaline      = true;
                                ^~~~~~~
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:389:32: error: 'struct libraw_output_params_t' has no member named 'lclean'
             raw.imgdata.params.lclean       = m_parent->m_rawDecodingSettings.NRThreshold     * 5E-5;
                                ^~~~~~
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:390:32: error: 'struct libraw_output_params_t' has no member named 'cclean'
             raw.imgdata.params.cclean       = m_parent->m_rawDecodingSettings.NRChroThreshold * 5E-5;
                                ^~~~~~
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:391:32: error: 'struct libraw_output_params_t' has no member named 'cfa_clean'
             raw.imgdata.params.cfa_clean    = true;
                                ^~~~~~~~~
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:398:32: error: 'struct libraw_output_params_t' has no member named 'linenoise'
             raw.imgdata.params.linenoise    = 0;
                                ^~~~~~~~~
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:399:32: error: 'struct libraw_output_params_t' has no member named 'cfaline'
             raw.imgdata.params.cfaline      = false;
                                ^~~~~~~
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:400:32: error: 'struct libraw_output_params_t' has no member named 'lclean'
             raw.imgdata.params.lclean       = 0;
                                ^~~~~~
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:401:32: error: 'struct libraw_output_params_t' has no member named 'cclean'
             raw.imgdata.params.cclean       = 0;
                                ^~~~~~
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:402:32: error: 'struct libraw_output_params_t' has no member named 'cfa_clean'
             raw.imgdata.params.cfa_clean    = false;
                                ^~~~~~~~~
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:408:24: error: 'struct libraw_output_params_t' has no member named 'ca_correc'; did you mean 'exp_correc'?
     raw.imgdata.params.ca_correc  = m_parent->m_rawDecodingSettings.enableCACorrection;
                        ^~~~~~~~~
                        exp_correc
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:409:24: error: 'struct libraw_output_params_t' has no member named 'cared'
     raw.imgdata.params.cared      = m_parent->m_rawDecodingSettings.caMultiplier[0];
                        ^~~~~
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:410:24: error: 'struct libraw_output_params_t' has no member named 'cablue'
     raw.imgdata.params.cablue     = m_parent->m_rawDecodingSettings.caMultiplier[1];
                        ^~~~~~
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:464:24: error: 'struct libraw_output_params_t' has no member named 'eeci_refine'
     raw.imgdata.params.eeci_refine    = m_parent->m_rawDecodingSettings.eeciRefine;
                        ^~~~~~~~~~~
/build/krita-4.0.3/plugins/impex/raw/3rdparty/libkdcraw/src/kdcraw_p.cpp:465:24: error: 'struct libraw_output_params_t' has no member named 'es_med_passes'; did you mean 'med_passes'?
     raw.imgdata.params.es_med_passes  = m_parent->m_rawDecodingSettings.esMedPasses;
                        ^~~~~~~~~~~~~
                        med_passes

@infinisil
Copy link
Member

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 13, 2018

@infinisil the patch has been merged in Krita upstream and is part of v4.1.3 that was merged in #47776

This should be safe to merge now. cc @abbradar too

@c0bw3b c0bw3b self-assigned this Oct 13, 2018
@infinisil
Copy link
Member

Let's see

@GrahamcOfBorg build krita

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: krita

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: krita

Partial log (click to expand)

shrinking /nix/store/a7vqypi6gy02pkx157n62nvlfpmlxdjw-krita-4.1.3/lib/libkritawidgets.so.17.0.0
shrinking /nix/store/a7vqypi6gy02pkx157n62nvlfpmlxdjw-krita-4.1.3/lib/libkritawidgetutils.so.17.0.0
shrinking /nix/store/a7vqypi6gy02pkx157n62nvlfpmlxdjw-krita-4.1.3/lib/libkritaplugin.so.17.0.0
shrinking /nix/store/a7vqypi6gy02pkx157n62nvlfpmlxdjw-krita-4.1.3/lib/libkritaglobal.so.17.0.0
shrinking /nix/store/a7vqypi6gy02pkx157n62nvlfpmlxdjw-krita-4.1.3/lib/libkritaversion.so.17.0.0
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a7vqypi6gy02pkx157n62nvlfpmlxdjw-krita-4.1.3/lib  /nix/store/a7vqypi6gy02pkx157n62nvlfpmlxdjw-krita-4.1.3/bin
patching script interpreter paths in /nix/store/a7vqypi6gy02pkx157n62nvlfpmlxdjw-krita-4.1.3
checking for references to /build in /nix/store/a7vqypi6gy02pkx157n62nvlfpmlxdjw-krita-4.1.3...
postPatchMkspecs

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: krita

Partial log (click to expand)

[ 23%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/kis_update_selection_job.cpp.o
[ 23%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/kis_serializable_configuration.cc.o
[ 23%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/kis_transaction_data.cpp.o
[ 23%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/kis_transform_worker.cc.o
[ 23%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/kis_perspectivetransform_worker.cpp.o
[ 23%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/bsplines/kis_bspline_1d.cpp.o
[ 24%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/bsplines/kis_bspline_2d.cpp.o
[ 24%] Building CXX object libs/image/CMakeFiles/kritaimage.dir/bsplines/kis_nu_bspline_2d.cpp.o
building of '/nix/store/c0bp6akzqxrrpwrhcwaglhqbkabma2hb-krita-4.1.3.drv' timed out after 3600 seconds
error: build of '/nix/store/c0bp6akzqxrrpwrhcwaglhqbkabma2hb-krita-4.1.3.drv' failed

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One platform is good enough for me (the chance of it failing on the other is near zero)

@infinisil infinisil merged commit cf7c4fb into NixOS:master Oct 13, 2018
@r-ryantm r-ryantm deleted the auto-update/libraw branch October 13, 2018 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants