Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dwarf-fortress: Run legends-browser with a suitable working directory #43057

Merged
merged 1 commit into from Jul 5, 2018

Conversation

Baughn
Copy link
Contributor

@Baughn Baughn commented Jul 4, 2018

Motivation for this change

It turns out that legends-browser leaves its configuration file in the current directory, whatever that is.

This wrapper makes sure it'll use df_linux, where all the other tools put theirs, and also sets a correct initial world-load path.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Baughn
Copy link
Contributor Author

Baughn commented Jul 4, 2018

@matthewbauer -- One for you, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants