Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: 10.5.0 -> 10.6.0 #43063

Merged
merged 1 commit into from Jul 5, 2018
Merged

nodejs: 10.5.0 -> 10.6.0 #43063

merged 1 commit into from Jul 5, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 5, 2018 •
edited

Motivation for this change

https://nodejs.org/en/blog/release/v10.6.0/

depends on: 97b23e1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@adisbladis adisbladis changed the base branch from master to staging July 5, 2018 06:00
@adisbladis
Copy link
Member

Thanks! I rebased your contribution on top of staging so it will reach master at the same time as the required libuv upgrade.

@GrahamcOfBorg build nodejs-10_x

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: nodejs-10_x

Partial log (click to expand)

cannot build derivation '/nix/store/z7gjls4mv5y5xkq6b512vzq5159x43ds-apple-framework-ServiceManagement.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/hl1pskknnxrja1wpqxadkg8485qg6mgx-apple-framework-SystemConfiguration.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/7s8k9pfbvaq0bd2836avwcw9hfkc0c3n-apple-framework-CoreGraphics.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/cmj0wq6b57han77l3zf10j901b5bgqlf-apple-framework-CoreServices.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/vdxzlig1i1pfk6vkyrlffc555qfizx4s-apple-framework-CoreText.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/mywysyckjnlw0phhh42jfpmhg2s33vwp-apple-framework-ImageIO.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/m4yljly9vzg02q55hwwr97bz3a4i4g2i-apple-framework-ApplicationServices.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/8idh3gqf55h75w10kv8dibgzdw7v6pfp-libuv-1.21.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/6s7l95774kbl2r61rmqj5nlcm1n1zmly-nodejs-10.6.0.drv': 12 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/6s7l95774kbl2r61rmqj5nlcm1n1zmly-nodejs-10.6.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: nodejs-10_x

Partial log (click to expand)

../deps/v8/src/isolate.cc:787:77: warning: 'code_offset' may be used uninitialized in this function [-Wmaybe-uninitialized]
       auto new_cache = SimpleNumberDictionary::Set(cache, code_offset, frame);
                                                                             ^
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.13"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.6.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.6.0/out/Release/.deps//build/node-v10.6.0/out/Release/obj.target/v8_base/deps/v8/src/json-parser.o.d.raw   -c -o /build/node-v10.6.0/out/Release/obj.target/v8_base/deps/v8/src/json-parser.o ../deps/v8/src/json-parser.cc
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.13"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.6.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.6.0/out/Release/.deps//build/node-v10.6.0/out/Release/obj.target/v8_base/deps/v8/src/json-stringifier.o.d.raw   -c -o /build/node-v10.6.0/out/Release/obj.target/v8_base/deps/v8/src/json-stringifier.o ../deps/v8/src/json-stringifier.cc
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.13"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.6.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.6.0/out/Release/.deps//build/node-v10.6.0/out/Release/obj.target/v8_base/deps/v8/src/keys.o.d.raw   -c -o /build/node-v10.6.0/out/Release/obj.target/v8_base/deps/v8/src/keys.o ../deps/v8/src/keys.cc
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.13"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.6.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.6.0/out/Release/.deps//build/node-v10.6.0/out/Release/obj.target/v8_base/deps/v8/src/layout-descriptor.o.d.raw   -c -o /build/node-v10.6.0/out/Release/obj.target/v8_base/deps/v8/src/layout-descriptor.o ../deps/v8/src/layout-descriptor.cc
  g++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.13"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/build/node-v10.6.0/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /build/node-v10.6.0/out/Release/.deps//build/node-v10.6.0/out/Release/obj.target/v8_base/deps/v8/src/log-utils.o.d.raw   -c -o /build/node-v10.6.0/out/Release/obj.target/v8_base/deps/v8/src/log-utils.o ../deps/v8/src/log-utils.cc
building of '/nix/store/3gcrcfv9zlf15zdwbbryamjpcpyqvqid-nodejs-10.6.0.drv' timed out after 3600 seconds
error: build of '/nix/store/3gcrcfv9zlf15zdwbbryamjpcpyqvqid-nodejs-10.6.0.drv' failed

@adisbladis adisbladis merged commit c120f69 into NixOS:staging Jul 5, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nodejs-10_x

Partial log (click to expand)

└───────────────────────────────────────────────────────────────┘
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9nlm27cjra9p8j26kdrj2caggpa8q3kk-nodejs-10.6.0
shrinking /nix/store/9nlm27cjra9p8j26kdrj2caggpa8q3kk-nodejs-10.6.0/bin/node
gzipping man pages under /nix/store/9nlm27cjra9p8j26kdrj2caggpa8q3kk-nodejs-10.6.0/share/man/
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9nlm27cjra9p8j26kdrj2caggpa8q3kk-nodejs-10.6.0/lib  /nix/store/9nlm27cjra9p8j26kdrj2caggpa8q3kk-nodejs-10.6.0/bin
patching script interpreter paths in /nix/store/9nlm27cjra9p8j26kdrj2caggpa8q3kk-nodejs-10.6.0
checking for references to /build in /nix/store/9nlm27cjra9p8j26kdrj2caggpa8q3kk-nodejs-10.6.0...
/nix/store/9nlm27cjra9p8j26kdrj2caggpa8q3kk-nodejs-10.6.0

@marsam marsam deleted the feature/update-nodejs-10_x branch July 5, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @adisbladis @GrahamcOfBorg