Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: fix build with libuv 1.21 (on staging) #43052

Merged
merged 1 commit into from Jul 4, 2018
Merged

cmake: fix build with libuv 1.21 (on staging) #43052

merged 1 commit into from Jul 4, 2018

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Jul 4, 2018

Motivation for this change

Fixes build of cmake 3.11, 3.10 and 3.9 with libuv 1.21 (on staging since #42986).

Upstream will release the fix with cmake 3.12.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@orivej-nixos orivej-nixos merged commit e7facc7 into NixOS:staging Jul 4, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cmake

Partial log (click to expand)

shrinking /nix/store/j3kf1kxnm28rwvzqiad7whhis86hxylm-cmake-3.11.2/bin/cpack
shrinking /nix/store/j3kf1kxnm28rwvzqiad7whhis86hxylm-cmake-3.11.2/bin/ctest
shrinking /nix/store/j3kf1kxnm28rwvzqiad7whhis86hxylm-cmake-3.11.2/bin/cmake
strip is /nix/store/7iyn7gn33i7xxjgmwf25k20246y6nd9d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j3kf1kxnm28rwvzqiad7whhis86hxylm-cmake-3.11.2/bin
patching script interpreter paths in /nix/store/j3kf1kxnm28rwvzqiad7whhis86hxylm-cmake-3.11.2
/nix/store/j3kf1kxnm28rwvzqiad7whhis86hxylm-cmake-3.11.2/share/cmake-3.11/Modules/CPack.STGZ_Header.sh.in: interpreter directive changed from "/bin/sh" to "/nix/store/3swzdhnphnbxjcyx2bkk1gh9k8gi3kl6-bash-4.4-p23/bin/sh"
/nix/store/j3kf1kxnm28rwvzqiad7whhis86hxylm-cmake-3.11.2/share/cmake-3.11/Modules/Squish4RunTestCase.sh: interpreter directive changed from "/bin/sh" to "/nix/store/3swzdhnphnbxjcyx2bkk1gh9k8gi3kl6-bash-4.4-p23/bin/sh"
/nix/store/j3kf1kxnm28rwvzqiad7whhis86hxylm-cmake-3.11.2/share/cmake-3.11/Modules/SquishRunTestCase.sh: interpreter directive changed from "/bin/sh" to "/nix/store/3swzdhnphnbxjcyx2bkk1gh9k8gi3kl6-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/j3kf1kxnm28rwvzqiad7whhis86hxylm-cmake-3.11.2...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cmake

Partial log (click to expand)

shrinking /nix/store/rqkg64ca6ipssy2zlylv4qa0anzshchj-cmake-3.11.2/bin/cmake
shrinking /nix/store/rqkg64ca6ipssy2zlylv4qa0anzshchj-cmake-3.11.2/bin/ctest
shrinking /nix/store/rqkg64ca6ipssy2zlylv4qa0anzshchj-cmake-3.11.2/bin/cpack
strip is /nix/store/90vmpr41dzsx350k5argycaf693hnl1l-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rqkg64ca6ipssy2zlylv4qa0anzshchj-cmake-3.11.2/bin
patching script interpreter paths in /nix/store/rqkg64ca6ipssy2zlylv4qa0anzshchj-cmake-3.11.2
/nix/store/rqkg64ca6ipssy2zlylv4qa0anzshchj-cmake-3.11.2/share/cmake-3.11/Modules/CPack.STGZ_Header.sh.in: interpreter directive changed from "/bin/sh" to "/nix/store/z9qg7lpkrajdnlgw5pxp9yx984prl1fi-bash-4.4-p23/bin/sh"
/nix/store/rqkg64ca6ipssy2zlylv4qa0anzshchj-cmake-3.11.2/share/cmake-3.11/Modules/SquishRunTestCase.sh: interpreter directive changed from "/bin/sh" to "/nix/store/z9qg7lpkrajdnlgw5pxp9yx984prl1fi-bash-4.4-p23/bin/sh"
/nix/store/rqkg64ca6ipssy2zlylv4qa0anzshchj-cmake-3.11.2/share/cmake-3.11/Modules/Squish4RunTestCase.sh: interpreter directive changed from "/bin/sh" to "/nix/store/z9qg7lpkrajdnlgw5pxp9yx984prl1fi-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/rqkg64ca6ipssy2zlylv4qa0anzshchj-cmake-3.11.2...

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: cmake

Partial log (click to expand)

cannot build derivation '/nix/store/z7gjls4mv5y5xkq6b512vzq5159x43ds-apple-framework-ServiceManagement.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/hl1pskknnxrja1wpqxadkg8485qg6mgx-apple-framework-SystemConfiguration.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/7s8k9pfbvaq0bd2836avwcw9hfkc0c3n-apple-framework-CoreGraphics.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/cmj0wq6b57han77l3zf10j901b5bgqlf-apple-framework-CoreServices.drv': 12 dependencies couldn't be built
cannot build derivation '/nix/store/vdxzlig1i1pfk6vkyrlffc555qfizx4s-apple-framework-CoreText.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/mywysyckjnlw0phhh42jfpmhg2s33vwp-apple-framework-ImageIO.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/m4yljly9vzg02q55hwwr97bz3a4i4g2i-apple-framework-ApplicationServices.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/8idh3gqf55h75w10kv8dibgzdw7v6pfp-libuv-1.21.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/58r456xdddl4whgc0mjsr7gddkai667f-cmake-3.11.2.drv': 15 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/58r456xdddl4whgc0mjsr7gddkai667f-cmake-3.11.2.drv' failed

@orivej orivej deleted the cmake branch March 29, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @GrahamcOfBorg @orivej-nixos