Darwin stdenv tweaks #43040
Merged
Darwin stdenv tweaks #43040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken & apparently unused.
It’s not a good idea to rely on apple’s sdk for such a core library in Nixpkgs. I have made a patch to libuv to make these frameworks optional. There is also a pull request here: libuv/libuv#1909
I want these tests to run because libuv is very important to lots of things in Nixpkgs. I have a very large list of tests to disable for now just to be on the safe side. For the record this is definitely a libuv issue - their tests should be robust - but this is a safety precaution for now.
As requested by @domenkozar
GrahamcOfBorg
added
6.topic: darwin
|
Success on x86_64-linux (full log) Attempted: libuv The following builds were skipped because they don't evaluate on x86_64-linux: darwin.security_tool Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: libuv The following builds were skipped because they don't evaluate on aarch64-linux: darwin.security_tool Partial log (click to expand)
|
LnL7
approved these changes
Jul 4, 2018
| tdRegexp = lib.concatStringsSep "\\|" toDisable; | ||
| in lib.optionalString doCheck '' | ||
| sed '/${tdRegexp}/d' -i test/test-list.h | ||
| ''; | ||
|
|
||
| nativeBuildInputs = [ automake autoconf libtool pkgconfig ]; | ||
| buildInputs = stdenv.lib.optionals stdenv.isDarwin [ ApplicationServices CoreServices ]; |
| # For now the tests are just breaking large swaths of the nixpkgs binary cache for Darwin, | ||
| # and I'd rather have everything else work at all than have stronger assurance here. | ||
| doCheck = !stdenv.isDarwin; | ||
| doCheck = true; |
There was a problem hiding this comment.
I'd also prefer to run them, but dealing with the intermittent failures on hydra is really painful particularly for staging. Let's keep an eye on it, let's hope we can get rid of them like this.
There was a problem hiding this comment.
Yes - it's very weird that it fails so frequently. FWIW it's not just libuv that has issues on macOS with network failures. Could it be a kernel thing? Or maybe it's just no one else runs automated tests on macOS.
There was a problem hiding this comment.
I wish we could just drop libuv from cmake altogether - but apparently cmake doesn't support that for some weird reason.
| @@ -0,0 +1,176 @@ | |||
| From 6d03644817fb263489dc9fdf550bf1fac274fd8f Mon Sep 17 00:00:00 2001 | |||
|
Failure on x86_64-darwin (full log) Attempted: darwin.security_tool, libuv Partial log (click to expand)
|
|
@matthewbauer any number of this reduction to get an impression? |
matthewbauer
force-pushed
the
darwin-closure-reductions
branch
3 times, most recently
from
8b53aa0
to
30347ef
Compare
matthewbauer
force-pushed
the
darwin-closure-reductions
branch
from
30347ef
to
6202380
Compare
|
@periklis Sorry my title was a little misleading - these aren't reducing anything currently just preventing the SDK from getting in some places where it shouldn't be. |
|
Success on x86_64-linux (full log) Attempted: libuv The following builds were skipped because they don't evaluate on x86_64-linux: darwin.security_tool Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: libuv The following builds were skipped because they don't evaluate on aarch64-linux: darwin.security_tool Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: darwin.security_tool, libuv Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Also some miscellaneous tweaks.