Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpv: fix x11 support after #41902 #43029

Closed
wants to merge 1 commit into from
Closed

mpv: fix x11 support after #41902 #43029

wants to merge 1 commit into from

Conversation

acertain
Copy link
Contributor

@acertain acertain commented Jul 4, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Jul 4, 2018

Thank you! Could you post the output of mpv -vo help after this change?

@grahamc
Copy link
Member

grahamc commented Jul 4, 2018

@GrahamcOfBorg eval

@orivej
Copy link
Contributor

orivej commented Jul 4, 2018

@aszlig has commited this in 7a19228.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@acertain @orivej @grahamc @GrahamcOfBorg @orivej-nixos