Revert "pkgs/top-level/release.nix.nix: Use fetchGit if possible" #43042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 67d0a57. which caused evaluation errors in restricted eval mode, producing: error: access to URI '/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci' is forbidden in restricted mode
|
Will revert the revert soon. |
LnL7
added a commit
to LnL7/ofborg
that referenced
this pull request
Jul 4, 2018
…ions Using builtins.fetchGit is not allowed in restricted mode, but it's desirable for eg. the tarball build. So we avoid it for the evaluation checks. See NixOS/nixpkgs#43042
LnL7
added a commit
to LnL7/ofborg
that referenced
this pull request
Nov 21, 2018
…ions Using builtins.fetchGit is not allowed in restricted mode, but it's desirable for eg. the tarball build. So we avoid it for the evaluation checks. See NixOS/nixpkgs#43042
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 67d0a57.
which caused evaluation errors in restricted eval mode, producing:
error: access to URI
'/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci' is
forbidden in restricted mode
cc @edolstra