Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coursera-dl: 0.10.0 -> 0.11.4 #43050

Merged
merged 1 commit into from Jul 7, 2018
Merged

coursera-dl: 0.10.0 -> 0.11.4 #43050

merged 1 commit into from Jul 7, 2018

Conversation

alexfmpe
Copy link
Member

@alexfmpe alexfmpe commented Jul 4, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)

@alexfmpe alexfmpe mentioned this pull request Jul 4, 2018
Closed
dotlambda
dotlambda reviewed Jul 5, 2018
View reviewed changes
pkgs/applications/misc/coursera-dl/default.nix Outdated
@@ -5,20 +5,20 @@ let

in pythonPackages.buildPythonApplication rec {
name = "coursera-dl-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify pname instead.

@xeji
Copy link
Contributor

xeji commented Jul 5, 2018

@GrahamcOfBorg build coursera-dl

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: coursera-dl

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: coursera-dl

Partial log (click to expand)

coursera/test/test_credentials.py .......                                [ 46%]
coursera/test/test_downloaders.py ....................                   [ 59%]
coursera/test/test_filter.py .                                           [ 60%]
coursera/test/test_parsing.py sss.                                       [ 62%]
coursera/test/test_utils.py ....................................ss..s... [ 92%]
                                                                         [ 92%]
coursera/test/test_workflow.py ............                              [100%]

============= 142 passed, 9 skipped, 1 deselected in 4.14 seconds ==============
/nix/store/zyis8k7p11avamy77qq0lax9qy4ql9if-coursera-dl-0.11.4-0.11.4

dotlambda
dotlambda reviewed Jul 5, 2018
View reviewed changes
pkgs/applications/misc/coursera-dl/default.nix Outdated
@@ -4,21 +4,21 @@ let
pythonPackages = python3.pkgs;

in pythonPackages.buildPythonApplication rec {
name = "coursera-dl-${version}";
version = "0.10.0";
pname = "coursera-dl-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pname = "coursera-dl".

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: coursera-dl

Partial log (click to expand)

coursera/test/test_credentials.py .......                                [ 46%]
coursera/test/test_downloaders.py ....................                   [ 59%]
coursera/test/test_filter.py .                                           [ 60%]
coursera/test/test_parsing.py sss.                                       [ 62%]
coursera/test/test_utils.py ....................................ss..s... [ 92%]
                                                                         [ 92%]
coursera/test/test_workflow.py ............                              [100%]

============= 142 passed, 9 skipped, 1 deselected in 1.90 seconds ==============
/nix/store/v6xdlq4326b30d24wcaw7pd0ka81zdg1-coursera-dl-0.11.4-0.11.4

@dotlambda
Copy link
Member

@GrahamcOfBorg build coursera-dl

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: coursera-dl

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: coursera-dl

Partial log (click to expand)

coursera/test/test_credentials.py .......                                [ 46%]
coursera/test/test_downloaders.py ....................                   [ 59%]
coursera/test/test_filter.py .                                           [ 60%]
coursera/test/test_parsing.py sss.                                       [ 62%]
coursera/test/test_utils.py ....................................ss..s... [ 92%]
                                                                         [ 92%]
coursera/test/test_workflow.py ............                              [100%]

============= 142 passed, 9 skipped, 1 deselected in 4.18 seconds ==============
/nix/store/72q2qhinhydy7j8mp0x69v2jhv649cs2-coursera-dl-0.11.4

@dotlambda dotlambda merged commit 52d4d73 into NixOS:master Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexfmpe @xeji @GrahamcOfBorg @dotlambda