Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

termtekst: init -> 1.0 #43045

Merged
merged 1 commit into from Jul 6, 2018
Merged

termtekst: init -> 1.0 #43045

merged 1 commit into from Jul 6, 2018

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented Jul 4, 2018

Motivation for this change

After all these years, Teletekst (Dutch equivalent of Ceefax) still is one of the fastest way to learn about news, weather etc. Plus, this nimble implementation runs on the terminal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jul 4, 2018

@GrahamcOfBorg eval

@nlewo
Copy link
Member

nlewo commented Jul 6, 2018

@GrahamcOfBorg build termtekst

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: termtekst

Partial log (click to expand)

writing top-level names to termtekst.egg-info/top_level.txt
reading manifest file 'termtekst.egg-info/SOURCES.txt'
writing manifest file 'termtekst.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/61kq4353zmsvbjrka26bwimll9saqp1h-termtekst-1.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: termtekst

Partial log (click to expand)

writing top-level names to termtekst.egg-info/top_level.txt
reading manifest file 'termtekst.egg-info/SOURCES.txt'
writing manifest file 'termtekst.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/zp81gp3lvgxzn8275dnihqj24xy2hx7v-termtekst-1.0

@xeji xeji merged commit 5902e11 into NixOS:master Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@leenaars @grahamc @nlewo @GrahamcOfBorg @xeji