Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome3: simplify package set using makeScope #43104

Merged
merged 1 commit into from Jul 6, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jul 6, 2018

Motivation for this change

Makes overriding easier and the expression much more readable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @yegortimoshenko who did similar thing in Xfce (#33600), @worldofpeace who is interested in packaging pantheon

@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Jul 6, 2018
@jtojnar jtojnar merged commit 188e487 into NixOS:master Jul 6, 2018
@jtojnar jtojnar deleted the gnome3-scope branch July 15, 2018 16:14
@pukkamustard pukkamustard mentioned this pull request Jan 3, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants