Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gocryptfs: 1.1.1 -> 1.5 #43090

Merged
merged 2 commits into from Jul 6, 2018
Merged

gocryptfs: 1.1.1 -> 1.5 #43090

merged 2 commits into from Jul 6, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jul 5, 2018 •
edited

Motivation for this change

This bumps gocryptfs to version 1.5, with various useful fixes:

Bold marked applicable changelog entries:

  • Support extended attributes (xattr) in forward mode
  • Add -fsck function
  • Fix several symlink race attacks
  • Use memory pools for buffer handling
  • Parallelize file content encryption
  • Use HKDF to derive separate keys for GCM and EME

In addition, we also now build manpages and add darwin support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@flokli
gocryptfs: fix typo in folder name
dff0cfc
@flokli
gocryptfs: 1.1.1 -> 1.5
7e579aa 
Bold marked applicable changelog entries:

 - Support extended attributes (xattr) in forward mode<Paste>
 - Add -fsck function
 - Fix several symlink race attacks
 - Use memory pools for buffer handling
 - Parallelize file content encryption
 - Use HKDF to derive separate keys for GCM and EME
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: gocryptfs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gocryptfs

Partial log (click to expand)

/nix/store/4nxq95hgbbq8lbmak1hk138qgvr72x9w-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/package-source.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash -eu"
/nix/store/4nxq95hgbbq8lbmak1hk138qgvr72x9w-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/package-static.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash -eu"
/nix/store/4nxq95hgbbq8lbmak1hk138qgvr72x9w-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/package.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash -eu"
/nix/store/4nxq95hgbbq8lbmak1hk138qgvr72x9w-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/profiling/streaming-read.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash -eu"
/nix/store/4nxq95hgbbq8lbmak1hk138qgvr72x9w-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/profiling/streaming-write.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash -eu"
/nix/store/4nxq95hgbbq8lbmak1hk138qgvr72x9w-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/profiling/tar-extract.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash -eu"
/nix/store/4nxq95hgbbq8lbmak1hk138qgvr72x9w-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/profiling/write-trace.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash -eu"
/nix/store/4nxq95hgbbq8lbmak1hk138qgvr72x9w-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/test-without-openssl.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash -eu"
/nix/store/4nxq95hgbbq8lbmak1hk138qgvr72x9w-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/test.bash: interpreter directive changed from "/bin/bash" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/bash"
/nix/store/xqkwah226kiv4z6i0wbb8kl6mzf6cbkm-gocryptfs-v1.5-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gocryptfs

Partial log (click to expand)

/nix/store/i5qzl32ywrqhkmgff92fi5dnprasygyw-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/internal/stupidgcm/benchmark.bash: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/i5qzl32ywrqhkmgff92fi5dnprasygyw-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/crossbuild.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash -eu"
/nix/store/i5qzl32ywrqhkmgff92fi5dnprasygyw-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/test.bash: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/i5qzl32ywrqhkmgff92fi5dnprasygyw-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/profiling/tar-extract.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash -eu"
/nix/store/i5qzl32ywrqhkmgff92fi5dnprasygyw-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/profiling/write-trace.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash -eu"
/nix/store/i5qzl32ywrqhkmgff92fi5dnprasygyw-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/profiling/streaming-write.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash -eu"
/nix/store/i5qzl32ywrqhkmgff92fi5dnprasygyw-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/profiling/streaming-read.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash -eu"
/nix/store/i5qzl32ywrqhkmgff92fi5dnprasygyw-gocryptfs-v1.5/share/go/src/github.com/rfjakob/gocryptfs/build.bash: interpreter directive changed from "/bin/bash -eu" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash -eu"
checking for references to /build in /nix/store/i5qzl32ywrqhkmgff92fi5dnprasygyw-gocryptfs-v1.5...
/nix/store/wfv9rqz34axpm2jxg0sfvlrc29m04lhk-gocryptfs-v1.5-bin

@xeji xeji merged commit 5ea2eb7 into NixOS:master Jul 6, 2018
@flokli flokli deleted the gocryptfs-1.5 branch July 6, 2018 16:40
@flokli flokli mentioned this pull request Jul 6, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @GrahamcOfBorg @xeji