gnu-pw-mgr: init 2.3.2 #43100

qoelet · 2018-07-06T04:50:18Z

Motivation for this change

gnu-pw-mgr: init 2.3.2

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

dotlambda · 2018-07-06T08:43:15Z

pkgs/tools/security/gnu-pw-mgr/default.nix

+
+  meta = with lib; {
+    homepage = "https://www.gnu.org/software/gnu-pw-mgr/";
+    description = "GNU gnu-pw-mgr is a password manager designed to make it easy to reconstruct difficult passwords when they are needed, while limiting the risk of attack.";


https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

dotlambda · 2018-07-06T08:44:01Z

pkgs/tools/security/gnu-pw-mgr/default.nix

+stdenv.mkDerivation {
+  name = "gnu-pw-mgr-2.3.2";
+  src = fetchurl {
+    url = "http://ftp.gnu.org/gnu/gnu-pw-mgr/gnu-pw-mgr-2.3.2.tar.xz";


Please use ${name} in here.

dotlambda · 2018-07-06T08:44:22Z

pkgs/tools/security/gnu-pw-mgr/default.nix

+    homepage = "https://www.gnu.org/software/gnu-pw-mgr/";
+    description = "GNU gnu-pw-mgr is a password manager designed to make it easy to reconstruct difficult passwords when they are needed, while limiting the risk of attack.";
+    license = with licenses; [ gpl3Plus lgpl3Plus ];
+    platforms = platforms.all;


Did you test this on Darwin?

Nope, amended this to unix - would that be a more appropriate option?

No, platforms.unix includes Darwin. Use platforms.linux to exclude Darwin.

dotlambda · 2018-07-06T08:45:35Z

pkgs/tools/security/gnu-pw-mgr/default.nix

+    description = "GNU gnu-pw-mgr is a password manager designed to make it easy to reconstruct difficult passwords when they are needed, while limiting the risk of attack.";
+    license = with licenses; [ gpl3Plus lgpl3Plus ];
+    platforms = platforms.all;
+    maintainers = [ ];


Do you want to maintain this yourself? In this case please add a commit before the current one adding yourself to https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix.

That makes sense, done. Thanks for taking the time to review this PR!

dotlambda · 2018-07-06T08:47:30Z

pkgs/tools/security/gnu-pw-mgr/default.nix

+  ];
+
+  meta = with lib; {
+    homepage = "https://www.gnu.org/software/gnu-pw-mgr/";


xeji · 2018-07-06T10:24:59Z

pkgs/tools/security/gnu-pw-mgr/default.nix

+  };
+
+  buildInputs = [
+    autogen


autogen is not needed to build this, it can be dropped here and above

You're right. Updated buildInputs, thanks.

xeji · 2018-07-06T10:54:30Z

pkgs/tools/security/gnu-pw-mgr/default.nix

@@ -0,0 +1,20 @@
+{ stdenv, lib, fetchurl, autogen, gnulib }:


Drop autogen here as well because it is not used anymore.

xeji · 2018-07-06T10:57:48Z

pkgs/tools/security/gnu-pw-mgr/default.nix

+    description = "A password manager designed to make it easy to reconstruct difficult passwords";
+    license = with licenses; [ gpl3Plus lgpl3Plus ];
+    platforms = stdenv.lib.platforms.linux;
+    maintainers = [ ];


To become a maintainer for this package, add yourself here like this:
maintainers = with maintainers; [ qoelet ];

xeji · 2018-07-06T11:39:01Z

@GrahamcOfBorg build gnu-pw-mgr

GrahamcOfBorg · 2018-07-06T11:39:25Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gnu-pw-mgr

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-07-06T11:41:07Z

Success on x86_64-linux (full log)

Attempted: gnu-pw-mgr

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5x7y9d0wrylyzj6qbgpzv7c1c67mk1si-gnu-pw-mgr-2.3.2
shrinking /nix/store/5x7y9d0wrylyzj6qbgpzv7c1c67mk1si-gnu-pw-mgr-2.3.2/bin/gnu-pw-mgr
shrinking /nix/store/5x7y9d0wrylyzj6qbgpzv7c1c67mk1si-gnu-pw-mgr-2.3.2/bin/sort-pw-cfg
gzipping man pages under /nix/store/5x7y9d0wrylyzj6qbgpzv7c1c67mk1si-gnu-pw-mgr-2.3.2/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5x7y9d0wrylyzj6qbgpzv7c1c67mk1si-gnu-pw-mgr-2.3.2/bin
patching script interpreter paths in /nix/store/5x7y9d0wrylyzj6qbgpzv7c1c67mk1si-gnu-pw-mgr-2.3.2
checking for references to /build in /nix/store/5x7y9d0wrylyzj6qbgpzv7c1c67mk1si-gnu-pw-mgr-2.3.2...
/nix/store/5x7y9d0wrylyzj6qbgpzv7c1c67mk1si-gnu-pw-mgr-2.3.2

GrahamcOfBorg · 2018-07-06T11:41:36Z

Success on aarch64-linux (full log)

Attempted: gnu-pw-mgr

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/53h1gd8i9j5a839qvjk96cflw3lsyb3x-gnu-pw-mgr-2.3.2
shrinking /nix/store/53h1gd8i9j5a839qvjk96cflw3lsyb3x-gnu-pw-mgr-2.3.2/bin/sort-pw-cfg
shrinking /nix/store/53h1gd8i9j5a839qvjk96cflw3lsyb3x-gnu-pw-mgr-2.3.2/bin/gnu-pw-mgr
gzipping man pages under /nix/store/53h1gd8i9j5a839qvjk96cflw3lsyb3x-gnu-pw-mgr-2.3.2/share/man/
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/53h1gd8i9j5a839qvjk96cflw3lsyb3x-gnu-pw-mgr-2.3.2/bin
patching script interpreter paths in /nix/store/53h1gd8i9j5a839qvjk96cflw3lsyb3x-gnu-pw-mgr-2.3.2
checking for references to /build in /nix/store/53h1gd8i9j5a839qvjk96cflw3lsyb3x-gnu-pw-mgr-2.3.2...
/nix/store/53h1gd8i9j5a839qvjk96cflw3lsyb3x-gnu-pw-mgr-2.3.2

xeji · 2018-07-06T11:42:46Z

LGTM. Thank you for contributing to nixpkgs!

qoelet · 2018-07-06T15:05:30Z

@xeji @dotlambda thanks for patiently guiding me through this, my little knowledge of Nix grows a bit more!

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Jul 6, 2018

qoelet force-pushed the gnu-pw-mgr branch 2 times, most recently from a000d13 to 43fabba Compare July 6, 2018 05:56

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Jul 6, 2018

dotlambda reviewed Jul 6, 2018

View reviewed changes

qoelet force-pushed the gnu-pw-mgr branch 4 times, most recently from 28ac83a to bf650d3 Compare July 6, 2018 09:21

Add qoelet to maintainers

bf86e95

qoelet force-pushed the gnu-pw-mgr branch 2 times, most recently from 8600b91 to 7150a17 Compare July 6, 2018 09:33

xeji reviewed Jul 6, 2018

View reviewed changes

qoelet force-pushed the gnu-pw-mgr branch from 7150a17 to 7b7a59e Compare July 6, 2018 10:51

xeji reviewed Jul 6, 2018

View reviewed changes

gnu-pw-mgr: init 2.3.2

e921aa0

qoelet force-pushed the gnu-pw-mgr branch from 7b7a59e to e921aa0 Compare July 6, 2018 11:01

GrahamcOfBorg added 10.rebuild-darwin: 0 and removed 10.rebuild-darwin: 1-10 labels Jul 6, 2018

xeji merged commit d868a26 into NixOS:master Jul 6, 2018

qoelet deleted the gnu-pw-mgr branch July 6, 2018 15:05

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gnu-pw-mgr: init 2.3.2 #43100

gnu-pw-mgr: init 2.3.2 #43100

qoelet commented Jul 6, 2018 •

edited

dotlambda Jul 6, 2018 •

edited

qoelet Jul 6, 2018

dotlambda Jul 6, 2018

dotlambda Jul 6, 2018

qoelet Jul 6, 2018

xeji Jul 6, 2018

dotlambda Jul 6, 2018

qoelet Jul 6, 2018

dotlambda Jul 6, 2018

xeji Jul 6, 2018

qoelet Jul 6, 2018

xeji Jul 6, 2018

xeji Jul 6, 2018 •

edited

xeji commented Jul 6, 2018

GrahamcOfBorg commented Jul 6, 2018

GrahamcOfBorg commented Jul 6, 2018

GrahamcOfBorg commented Jul 6, 2018

xeji commented Jul 6, 2018

qoelet commented Jul 6, 2018

gnu-pw-mgr: init 2.3.2 #43100

gnu-pw-mgr: init 2.3.2 #43100

Conversation

qoelet commented Jul 6, 2018 • edited

Motivation for this change

Things done

dotlambda Jul 6, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xeji Jul 6, 2018 • edited

Choose a reason for hiding this comment

xeji commented Jul 6, 2018

GrahamcOfBorg commented Jul 6, 2018

GrahamcOfBorg commented Jul 6, 2018

GrahamcOfBorg commented Jul 6, 2018

xeji commented Jul 6, 2018

qoelet commented Jul 6, 2018

qoelet commented Jul 6, 2018 •

edited

dotlambda Jul 6, 2018 •

edited

xeji Jul 6, 2018 •

edited