Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSTU SRB #1902

Closed
wants to merge 17 commits into from
Closed

SSTU SRB #1902

wants to merge 17 commits into from

Conversation

DocRockwell
Copy link
Contributor

Fixed configs for SSTU solid rocket motors. RealFuel engineConfig switching between variants doesn't seem work, so the ISP is fixed, but the thrust switches at least. I set the minimum thrust to ~50% of max thrust, instead of being locked at max, so the performance can be tuned in the VAB.
The GEM booster needs its plume position adjusted, it's currently above the nozzle. The thrust on the GEM boosters might also need some tweaking, the 1.05 m diameter GEM40 looks alright, but increasing the diameter for the GEM46/60 causes thrust to scale to higher values than the real versions.

@DocRockwell
Copy link
Contributor Author

  • Got the RealFuel configs working
  • changed the GEM variants from generic to GEM40/46/60/63 with ground and air lit variants (not sure if the non-gimbaling variants can be put to use with SSTU controlling the mass and gimbals, could give them a reduced cost though)
  • Made RealPlume configs for the SRB's

@DocRockwell
Copy link
Contributor Author

The dry masses need some adjusting, they're to high. Tweaking the generic part mass and SSTU settings has no affect, I assume RealFuels is controlling the part mass. Is there a way to modify the mass with ModuleFuelTanks? @NathanKell

@PhineasFreak
Copy link
Contributor

Use basemass = -1 to disable the RF tank mass management.

@DocRockwell
Copy link
Contributor Author

Can you use basemass = x * volume in ModuleFuelTanks, or does that only work for TANK_DEFINITIONS?

@PhineasFreak
Copy link
Contributor

DocRockwell added a commit to DocRockwell/RP-0 that referenced this pull request Jul 10, 2018
-updated SSTU modular SRB's for RO pull request KSP-RO/RealismOverhaul#1902
-updated SSTU ICPS and EUS KSP-RO/RealismOverhaul#1910
-added SSTU MUS, Lander tanks and spherical tanks (just guessed at price and node)
-added SSTU HECS2 probe core and (developmental) Data Return Capsule. I've configured these for RO, will make pull request eventually.
-added BahaConstellation BNTR
@DocRockwell
Copy link
Contributor Author

Hmmm basemass = x * volume didn't work when I tried it on these parts. Getting the volume and drymass dialed in for these modular parts is proving to be tricky.

@DocRockwell
Copy link
Contributor Author

DocRockwell commented Jul 10, 2018

Updates:
-split GEM40/46/60 into two separate parts, made them less customizable
-GEM40/46: can no longer switch length, only 2 diameter options, added config for GEM40 GL/TVC
-GEM60/63/63XL: 2 diameter options, 3 length options corresponding to the GEM60/63/63xl. Volume and mass for these parts are good (mass set by engineconfig, but had to estimate GEM63 and 63XL mass from the dimensions of the boosters, no data in the Orbital ATK 2016 catalog, and the spacelaunchreport sight estimates seem spurious (63XL could not possibly have the same drymass as GEM46))
-UA120: pruned models that didn't match the length of UA1204,5,6,7 boosters. Engine configs restricted to the actual produced boosters. Volume is good, matches Raider Nicks parts.
-still struggling with drymass of UA120 boosters, used engineconfigs to force drymass, should probably lock diameter to 3.05 m.
-RSRM still pretty customizable, 1-6 segments, variable diameter. Performance needs to be tweaked for realism.
-Renamed parts from SSTU-RO-ENG-SRBA, -SRBC, SRBD to SSTU-RO-ENG-RSRM, -UA120, -GEM40, -GEM60. Seeing as these parts haven't been working for a while, I figured now is a good time to give them more sensible part names. Also updated the RO Tree parts spreadsheet to reflect this (will make PR later).
-updated and tweaked plume configs.

@DocRockwell
Copy link
Contributor Author

The RSRM boosters might be nice to keep fully customizable, especially if part tooling can be added. I think engineconfigs will have to be removed to let SSTU handle thrust scaling if diameter is to be adjustable though.

@raidernick raidernick added the Conflicts - Untested Has conflicts that need resolving but hasn't been tested label Sep 29, 2018
@raidernick
Copy link
Contributor

This needs to be redone with no conflicts, as it stands it can't be put into the latest RO release since it's been sitting too long. Reopen it when ready.

@raidernick raidernick closed this Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conflicts - Untested Has conflicts that need resolving but hasn't been tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants