Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seafile-client: 6.1.8 -> 6.2.1 #43106

Merged
merged 3 commits into from Jul 6, 2018
Merged

seafile-client: 6.1.8 -> 6.2.1 #43106

merged 3 commits into from Jul 6, 2018

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jul 6, 2018 •
edited

Motivation for this change

fixes #42772

Note that this is untested due to the issue with running applications built against different Qt versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: libsearpc, seafile-client, seafile-shared

Partial log (click to expand)

shrinking /nix/store/npgr2m022zi6qm3b1v1bw93cgmwlpk1y-ccnet-6.1.8/bin/ccnet-init
shrinking /nix/store/npgr2m022zi6qm3b1v1bw93cgmwlpk1y-ccnet-6.1.8/bin/ccnet
shrinking /nix/store/npgr2m022zi6qm3b1v1bw93cgmwlpk1y-ccnet-6.1.8/lib/libccnet.so.0.0.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/npgr2m022zi6qm3b1v1bw93cgmwlpk1y-ccnet-6.1.8/lib  /nix/store/npgr2m022zi6qm3b1v1bw93cgmwlpk1y-ccnet-6.1.8/bin
patching script interpreter paths in /nix/store/npgr2m022zi6qm3b1v1bw93cgmwlpk1y-ccnet-6.1.8
checking for references to /build in /nix/store/npgr2m022zi6qm3b1v1bw93cgmwlpk1y-ccnet-6.1.8...
cannot build derivation '/nix/store/lil8xxb2ak4s5j4dgx7nkmp2y11ch4zv-seafile-shared-6.2.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6x49jlyxi80ckryr0wsdsw9n2cd5zab8-seafile-client-6.2.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/6x49jlyxi80ckryr0wsdsw9n2cd5zab8-seafile-client-6.2.1.drv', '/nix/store/lil8xxb2ak4s5j4dgx7nkmp2y11ch4zv-seafile-shared-6.2.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: libsearpc, seafile-client, seafile-shared

Partial log (click to expand)

[6879/16620] STAMP obj/third_party/webrtc/pc/rtc_pc_base.inputdeps.stamp
[6880/16620] CXX obj/third_party/webrtc/modules/video_coding/webrtc_vp9/vp9_impl.o
[6881/16620] CXX obj/third_party/webrtc/modules/rtp_rtcp/rtp_rtcp/packet_loss_stats.o
[6882/16620] CXX obj/third_party/webrtc/modules/desktop_capture/desktop_capture_generic/desktop_frame_rotation.o
[6883/16620] CXX obj/third_party/webrtc/p2p/rtc_p2p/packetsocketfactory.o
[6884/16620] CXX obj/third_party/webrtc/modules/rtp_rtcp/rtp_rtcp_format/remb.o
[6885/16620] CXX obj/third_party/webrtc/modules/video_capture/video_capture_module/video_capture_factory.o
building of '/nix/store/iixzzbhh3arr5kjf3x6ndsfbgwv107qf-qtwebengine-5.11.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/99y98ay739pnl8yf9hy1is9p11hlbxjb-seafile-client-6.2.1.drv': 2 dependencies couldn't be built
error: build of '/nix/store/99y98ay739pnl8yf9hy1is9p11hlbxjb-seafile-client-6.2.1.drv', '/nix/store/jpf85i09yjxi6cl7kg84fmcd9b8vyrp9-seafile-shared-6.2.1.drv' failed

@xeji
Copy link
Contributor

xeji commented Jul 6, 2018

Source hash mismatch:

fixed-output derivation produced path '/nix/store/a8c958yhzma20xk6gkfg0lvba84jli88-source' with sha256 hash '199ivh6fbz4sgbz15mr6m8985yky5n3z6vpcpnh2ldjx4277gq68' instead of the expected hash '1qnsk0s1j74zx1h7z1cclamknfa74gbspj12g9lbi7all2s14943'

@dotlambda
Copy link
Member Author

Now I also tested the package and can confirm it works as expected 🎉

orivej
orivej reviewed Jul 6, 2018
View reviewed changes
pkgs/development/libraries/libsearpc/default.nix
repo = "libsearpc";
# Tag is missing: https://github.com/haiwen/libsearpc/commit/12a01268825e9c7e17794c58c367e3b4db912ad9
rev = "12a01268825e9c7e17794c58c367e3b4db912ad9";
sha256 = "00ck1hl1x0pn22q3ba32dq3ckc4nrsg58irsmrnmalqbsffhcim0";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that with their rolling v3.1-latest tag upstream wants us to ignore releases and always use the latest commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the difference between this commit and the latest is not important; feel free to keep using it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did what Arch (AUR) does: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=libsearpc

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libsearpc, seafile-client, seafile-shared

Partial log (click to expand)

shrinking /nix/store/lf8ij0hhm0mlsc7zjx3q8cp0zdrq7yb6-seafile-client-6.2.1/bin/.seafile-applet-wrapped
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lf8ij0hhm0mlsc7zjx3q8cp0zdrq7yb6-seafile-client-6.2.1/bin
patching script interpreter paths in /nix/store/lf8ij0hhm0mlsc7zjx3q8cp0zdrq7yb6-seafile-client-6.2.1
checking for references to /build in /nix/store/lf8ij0hhm0mlsc7zjx3q8cp0zdrq7yb6-seafile-client-6.2.1...
postPatchMkspecs
postPatchMkspecs
/nix/store/c58aysm2d588mh075k6i0dma637q0hhg-libsearpc-3.0.8
/nix/store/lf8ij0hhm0mlsc7zjx3q8cp0zdrq7yb6-seafile-client-6.2.1
/nix/store/6f8dayzvzg1g4vhb7cdcbbg2qy9hfn72-seafile-shared-6.2.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: libsearpc, seafile-client, seafile-shared

Partial log (click to expand)

[7228/16620] CXX obj/skia/skia/SkBitmapController.o
[7229/16620] CXX obj/skia/skia/SkBitmapDevice.o
[7230/16620] CXX obj/skia/skia/SkCachedData.o
[7231/16620] CXX obj/skia/skia/SkBlurImageFilter.o
[7232/16620] CXX obj/skia/skia/benchmarking_canvas.o
[7233/16620] CXX obj/skia/skia/SkBlitter_Sprite.o
[7234/16620] CXX obj/skia/skia/SkBitmapProvider.o
building of '/nix/store/iixzzbhh3arr5kjf3x6ndsfbgwv107qf-qtwebengine-5.11.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/6k1dj7iibxpzbf7zffx0jniwf0lz1i15-seafile-client-6.2.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/6k1dj7iibxpzbf7zffx0jniwf0lz1i15-seafile-client-6.2.1.drv' failed

@dotlambda dotlambda merged commit a49ac62 into NixOS:master Jul 6, 2018
@dotlambda dotlambda deleted the seafile-client-6.2.1 branch March 21, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seafile-client 6.1.8 fails to build
4 participants
@dotlambda @GrahamcOfBorg @xeji @orivej