mosdepth: init 0.2.3 #43096
mosdepth: init 0.2.3 #43096
Conversation
|
|
||
| buildPhase = "nim -p:${hts-nim}/src -p:${docopt}/src c -d:release mosdepth.nim"; | ||
| installPhase = "install -Dt $out/bin mosdepth"; | ||
| fixupPhase = "patchelf --set-rpath ${stdenv.cc.cc.lib}/lib:${makeLibraryPath [ stdenv.cc.cc htslib pcre ]} $out/bin/mosdepth"; |
There was a problem hiding this comment.
Should be the same as --set-rpath "${stdenv.lib.makeLibraryPath [ stdenv.cc.cc htslib pcre ]}"
| license = licenses.mit; | ||
| homepage = https://github.com/brentp/mosdepth; | ||
| maintainers = with maintainers; [ jbedo ]; | ||
| platforms = stdenv.lib.platforms.linux; |
There was a problem hiding this comment.
You can use platforms = platforms.linux; here as you have a with stdenv.lib; above.
| @@ -0,0 +1,43 @@ | |||
| {stdenv, fetchFromGitHub, nim, htslib, patchelf, pcre}: | |||
|
|
|||
| with { inherit (stdenv.lib) makeLibraryPath; }; | |||
There was a problem hiding this comment.
Remove this, and use stdenv.lib.makeLibraryPath directly.
Also, place a let in here and move the hts-nim and docopt sources here. Something like
{stdenv, fetchFromGitHub, nim, htslib, patchelf, pcre}:
let
hts-nim = fetchFromGitHub {
# ...
};
docopt = fetchFromGitHub {
# ...
};
in
stdenv.mkDerivation rec { ...|
|
||
| buildInputs = [ nim ]; | ||
|
|
||
| buildPhase = "nim -p:${hts-nim}/src -p:${docopt}/src c -d:release mosdepth.nim"; |
There was a problem hiding this comment.
Does Nim require you to have the dependencies sources in order to use them?
There was a problem hiding this comment.
Unfortunately yes, there doesn't seem to be a better way of packaging nim apps atm.
| hts-nim = fetchFromGitHub { | ||
| owner = "brentp"; | ||
| repo = "hts-nim"; | ||
| rev = "9cd83e3"; |
There was a problem hiding this comment.
Use either a full git hash or a tag here instead
Motivation for this change
mosdepth: init 0.2.3
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)