Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor python type_getattro patch. #43112

Closed
wants to merge 1 commit into from
Closed

Vendor python type_getattro patch. #43112

wants to merge 1 commit into from

Conversation

waynr
Copy link
Contributor

@waynr waynr commented Jul 6, 2018

Motivation for this change

Prior to this, builds of Python 2.7 were failing most likely due to a rebase in the upstream pull request from which it was being retrieved previously (python/cpython#6118).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (in progress)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@waynr waynr requested a review from FRidh as a code owner July 6, 2018 11:56
@waynr
Copy link
Contributor Author

waynr commented Jul 7, 2018

Closing this because @orivej merged #43130

@waynr waynr closed this Jul 7, 2018
@orivej-nixos
Copy link
Contributor

Sorry, didn't notice this, but this was a mass rebuild that could not have been merged to master.

@waynr waynr deleted the fix-python-patch branch July 9, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@waynr @orivej-nixos @GrahamcOfBorg @Janik-Haag