Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox, firefox-bin: 61.0 -> 61.0.1 #43113

Merged
merged 2 commits into from Jul 7, 2018
Merged

firefox, firefox-bin: 61.0 -> 61.0.1 #43113

merged 2 commits into from Jul 7, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jul 6, 2018

Motivation for this change
  • Bug fixes

https://www.mozilla.org/en-US/firefox/61.0.1/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Not tested yet

@xeji
Copy link
Contributor

xeji commented Jul 6, 2018

This can go to master, only 30 rebuilds.

@xeji xeji changed the base branch from staging to master July 6, 2018 17:38
@GrahamcOfBorg GrahamcOfBorg added 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: python 6.topic: xfce The Xfce Desktop Environment 8.has: module (update) labels Jul 6, 2018
@xeji
Copy link
Contributor

xeji commented Jul 6, 2018

@taku0 sorry, I tried changing the base to master but it messed up the PR. Please rebase your changes on master manually. I'm closing this because it's typically less work to open a new PR than to clean this up. Thank you.

@xeji xeji closed this Jul 6, 2018
@vcunat vcunat reopened this Jul 6, 2018
@vcunat
Copy link
Member

vcunat commented Jul 6, 2018

Resurrected by me, though I guess the context above could be a bit annoying.

@GrahamcOfBorg GrahamcOfBorg removed 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: python 6.topic: xfce The Xfce Desktop Environment labels Jul 6, 2018
@vcunat vcunat self-assigned this Jul 7, 2018
vcunat
vcunat approved these changes Jul 7, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both seem to work fine.

@vcunat vcunat merged commit 09918a6 into NixOS:master Jul 7, 2018
vcunat added a commit that referenced this pull request Jul 7, 2018
@vcunat
Merge #43113: firefox*: 61.0 -> 61.0.1
6ea4c3d
vcunat added a commit that referenced this pull request Jul 7, 2018
@vcunat
Merge #43113: firefox*: 61.0 -> 61.0.1
249463f 
(cherry picked from commit 6ea4c3d)
@vcunat vcunat added 8.has: port to stable A PR already has a backport to the stable release. and removed 8.has: clean-up 8.has: package (new) labels Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @xeji @vcunat @GrahamcOfBorg