Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

josm: bump to jre10 #43073

Closed
wants to merge 1 commit into from
Closed

josm: bump to jre10 #43073

wants to merge 1 commit into from

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Jul 5, 2018

Fixes https://josm.openstreetmap.de/ticket/11806

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: josm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@Ekleog Ekleog mentioned this pull request Jul 5, 2018
Closed
9 tasks
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: josm

Partial log (click to expand)

strange: no string table
strange: no string table
strange: no string table
strange: no string table
strange: no string table
strange: no string table
strange: no string table
building '/nix/store/cjf90gd8lsyfpcshmjm1d4cd87hr5a77-josm-13996.drv'...
'/nix/store/rr0yndzlraq4x0p72lf2qg455hpr7arw-josm-snapshot-13996.jar' -> '/nix/store/c08nk8x2qy7fa0msqn02aca1hgqy48pc-josm-13996/share/java/josm.jar'
/nix/store/c08nk8x2qy7fa0msqn02aca1hgqy48pc-josm-13996

@rycee rycee self-assigned this Jul 5, 2018
@rycee
Copy link
Member

rycee commented Jul 5, 2018

Rebased to master in 806e5a3. Thanks a lot for the contribution!

@rycee rycee closed this Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rycee rycee

Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @GrahamcOfBorg @rycee