Rework stage.nix's extraPkgs #43079
Merged
Rework stage.nix's extraPkgs #43079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have renamed the overlay to “otherPackageSets” because I think that is more descriptive. pkgsLocal has been removed because there were concerns that it would be confusing. None of the other names seemed very useful so I think it is best to avoid it altogether. pkgsCross is still included, hopefully, that will not have as much confusion. pkgsMusl is now available for building Musl packages. It will give you packages bulit with the Musl libc. Also added more documentation. /cc @dezgeg @Ericson2314 @dtzWill
This has been replaced with pkgsi686Linux.callPackage
matthewbauer
requested review from
dezgeg and
dtzWill
and removed request for
nbp
Ericson2314
approved these changes
Jul 5, 2018
…System more For example: nix-repl> pkgsi686Linux.pkgsMusl.hostPlatform.config "i686-unknown-linux-musl" nix-repl> pkgsMusl.pkgsi686Linux.hostPlatform.config "i686-unknown-linux-musl"
This prevent us evaluation on macOS systems where pkgsMusl & pkgsi686Linux is unsupported.
|
\o/ \o/ \o/ |
|
Any chance you could:
This broke a bunch of my stuff, and the only way to figure out how and why was to |
|
Yeah that would be a good idea. |
|
Thank you a lot! |
|
I think there is a pretty critical issue in forceSystem where the .drv is different for each host system. We can probably try to fix it but it could get a little complicated with trying to avoid that bug. Are you just using forceSystem for i686? Maybe we can just point it to pkgsi686Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have renamed the overlay to “otherPackageSets” because I think that
is more descriptive.
pkgsLocal has been removed because there were concerns that it would
be confusing. None of the other names seemed very useful so I think it
is best to avoid it altogether. pkgsCross is still included,
hopefully, that will not have as much confusion.
pkgsMusl is now available for building Musl packages. It will give you
packages bulit with the Musl libc.
Also added more documentation.
/cc @dezgeg @Ericson2314 @dtzWill