Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emscripten: 1.37.16 -> 1.38.6, Add mupf to maintainer list #43078

Closed
wants to merge 1 commit into from
Closed

emscripten: 1.37.16 -> 1.38.6, Add mupf to maintainer list #43078

wants to merge 1 commit into from

Conversation

mupfdev
Copy link

@mupfdev mupfdev commented Jul 5, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mupfdev
Copy link
Author

mupfdev commented Jul 5, 2018

This is quite odd: the diff in the default.nix doesn't look like the change I made. I only changed the sha256 hash, the version number and added myself to the list of package maintainers.

@mupfdev mupfdev closed this Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mupfdev @GrahamcOfBorg