Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Josm 13996 #43075

Closed
wants to merge 2 commits into from
Closed

Josm 13996 #43075

wants to merge 2 commits into from

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Jul 5, 2018 •
edited

Motivation for this change

Note: this builds upon #43073 because that's the order in which I prepared these PRs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: josm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: josm

Partial log (click to expand)

/nix/store/c08nk8x2qy7fa0msqn02aca1hgqy48pc-josm-13996

@rycee
Copy link
Member

rycee commented Jul 5, 2018

Thanks for the PR but I already updated JOSM in master three days ago: 033c9ac 🙂

@rycee rycee closed this Jul 5, 2018
@Ekleog
Copy link
Member Author

Ekleog commented Jul 6, 2018

OK great, thanks! I had checked from the latest bump of unstable where it wasn't yet, I guess :)

@Ekleog Ekleog deleted the josm-13996 branch July 6, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @GrahamcOfBorg @rycee