Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: 0.10.1 -> 0.11.2 #43076

Merged
merged 1 commit into from Jul 6, 2018
Merged

kitty: 0.10.1 -> 0.11.2 #43076

merged 1 commit into from Jul 6, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 5, 2018

Version bump!

https://sw.kovidgoyal.net/kitty/changelog.html

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

In order to test on my 18.03-based NixOS machine I had to also pull in glibcLocales from master;
this is the same issue we're seeing everywhere but here instead of warning causes error.

@dtzWill
Copy link
Member Author

dtzWill commented Jul 5, 2018

Functionality testing by someone familiar with this would be appreciated!

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: kitty

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kitty

Partial log (click to expand)

shrinking /nix/store/13r0fr3lhy7ivradwrdgp86v74lawng9-kitty-0.11.2/lib/kitty/kitty/glfw-x11.so
shrinking /nix/store/13r0fr3lhy7ivradwrdgp86v74lawng9-kitty-0.11.2/lib/kitty/kitty/fast_data_types.so
shrinking /nix/store/13r0fr3lhy7ivradwrdgp86v74lawng9-kitty-0.11.2/bin/.kitty-wrapped
gzipping man pages under /nix/store/13r0fr3lhy7ivradwrdgp86v74lawng9-kitty-0.11.2/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/13r0fr3lhy7ivradwrdgp86v74lawng9-kitty-0.11.2/lib  /nix/store/13r0fr3lhy7ivradwrdgp86v74lawng9-kitty-0.11.2/bin
patching script interpreter paths in /nix/store/13r0fr3lhy7ivradwrdgp86v74lawng9-kitty-0.11.2
/nix/store/13r0fr3lhy7ivradwrdgp86v74lawng9-kitty-0.11.2/lib/kitty/kitty/launcher/kitty: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/pz8nl4cnppd3p1cykshcb40mqxjd5yvy-python3-3.6.5/bin/python3"
checking for references to /build in /nix/store/13r0fr3lhy7ivradwrdgp86v74lawng9-kitty-0.11.2...
/nix/store/13r0fr3lhy7ivradwrdgp86v74lawng9-kitty-0.11.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kitty

Partial log (click to expand)

shrinking /nix/store/fg4g6c7bg2i8pj9k47saa4pl20fbhraj-kitty-0.11.2/lib/kitty/kitty/glfw-x11.so
shrinking /nix/store/fg4g6c7bg2i8pj9k47saa4pl20fbhraj-kitty-0.11.2/lib/kitty/kitty/glfw-wayland.so
shrinking /nix/store/fg4g6c7bg2i8pj9k47saa4pl20fbhraj-kitty-0.11.2/bin/.kitty-wrapped
gzipping man pages under /nix/store/fg4g6c7bg2i8pj9k47saa4pl20fbhraj-kitty-0.11.2/share/man/
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fg4g6c7bg2i8pj9k47saa4pl20fbhraj-kitty-0.11.2/lib  /nix/store/fg4g6c7bg2i8pj9k47saa4pl20fbhraj-kitty-0.11.2/bin
patching script interpreter paths in /nix/store/fg4g6c7bg2i8pj9k47saa4pl20fbhraj-kitty-0.11.2
/nix/store/fg4g6c7bg2i8pj9k47saa4pl20fbhraj-kitty-0.11.2/lib/kitty/kitty/launcher/kitty: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/bypq8sfxwrzn5c9zpa03vif4vb8ly2kk-python3-3.6.5/bin/python3"
checking for references to /build in /nix/store/fg4g6c7bg2i8pj9k47saa4pl20fbhraj-kitty-0.11.2...
/nix/store/fg4g6c7bg2i8pj9k47saa4pl20fbhraj-kitty-0.11.2

@dtzWill
Copy link
Member Author

dtzWill commented Jul 5, 2018

cc @jlesquembre

@jlesquembre
Copy link
Member

@dtzWill tested it with nixos-unstable and it looks good. Thanks!

@dtzWill
Copy link
Member Author

dtzWill commented Jul 6, 2018

Great, thank you!

@dtzWill dtzWill merged commit 7835d7c into NixOS:master Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @jlesquembre