Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rPackages.RcppEigen: fix Darwin build #42289

Merged
merged 1 commit into from Jun 20, 2018
Merged

rPackages.RcppEigen: fix Darwin build #42289

merged 1 commit into from Jun 20, 2018

Conversation

mnacamura
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mnacamura mnacamura requested a review from peti as a code owner June 20, 2018 01:40
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Jun 20, 2018
matthewbauer
matthewbauer reviewed Jun 20, 2018
View reviewed changes
pkgs/development/r-modules/default.nix Outdated
@@ -397,6 +397,7 @@ let
RPushbullet = [ pkgs.which ];
qtpaint = [ pkgs.cmake ];
qtbase = [ pkgs.cmake pkgs.perl ];
RcppEigen = lib.optionals stdenv.isDarwin [ pkgs.libiconv ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you are trying to avoid a mass rebuild, I would recommend getting rid of the conditional. libiconv is set up to give you the right version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I see.

@LnL7
Copy link
Member

LnL7 commented Jun 20, 2018

@GrahamcOfBorg build rPackages.RcppEigen

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rPackages.RcppEigen

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rPackages.RcppEigen

Partial log (click to expand)

** help
*** installing help indices
** building package indices
** installing vignettes
** testing if installed package can be loaded
* DONE (RcppEigen)
post-installation fixup
strip is /nix/store/8q05v40n0f7amgw70pk6bkb23r7hrzgn-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/dlj4kqy3akvypbadn8h4ksfxnxkqy573-r-RcppEigen-0.3.3.4.0
/nix/store/dlj4kqy3akvypbadn8h4ksfxnxkqy573-r-RcppEigen-0.3.3.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rPackages.RcppEigen

Partial log (click to expand)

** installing vignettes
** testing if installed package can be loaded
* DONE (RcppEigen)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h94sch7rvprv0whj682ivb7asmx5jwf2-r-RcppEigen-0.3.3.4.0
shrinking /nix/store/h94sch7rvprv0whj682ivb7asmx5jwf2-r-RcppEigen-0.3.3.4.0/library/RcppEigen/libs/RcppEigen.so
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/h94sch7rvprv0whj682ivb7asmx5jwf2-r-RcppEigen-0.3.3.4.0
checking for references to /build in /nix/store/h94sch7rvprv0whj682ivb7asmx5jwf2-r-RcppEigen-0.3.3.4.0...
/nix/store/h94sch7rvprv0whj682ivb7asmx5jwf2-r-RcppEigen-0.3.3.4.0

@matthewbauer matthewbauer merged commit d62db0b into NixOS:master Jun 20, 2018
@mnacamura mnacamura deleted the r-RcppEigen-darwin branch June 21, 2018 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mnacamura @LnL7 @GrahamcOfBorg @matthewbauer