Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhall-json_1_2_0: fix dependencies #42265

Closed
wants to merge 1 commit into from
Closed

dhall-json_1_2_0: fix dependencies #42265

wants to merge 1 commit into from

Conversation

philandstuff
Copy link
Contributor

@philandstuff philandstuff commented Jun 19, 2018

dhall-json 1.2.0 requires dhall's version to be at least 1.14.0 and less
than 1.15.0. The package wasn't building for me because dhall is at
version 1.11.1; pinning to dhall_1_14_0 fixed it.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

dhall-json 1.2.0 requires dhall's version to be at least 1.14.0 and less
than 1.15.0.  The package wasn't building for me because `dhall` is at
version 1.11.1; pinning to `dhall_1_14_0` fixed it.
@philandstuff philandstuff requested a review from peti as a code owner June 19, 2018 19:13
@philandstuff
Copy link
Contributor Author

oops, apparently hackage-packages.nix is autogenerated and shouldn't be edited. will close and reopen with a proper fix

@philandstuff philandstuff deleted the fix-dhall-json-1.2.0 branch June 19, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant